Skip to content

Commit 7456371

Browse files
authored
Remove duplicate role definition (#39)
1 parent ff32a28 commit 7456371

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

main.tf

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -359,15 +359,6 @@ module "launch_system" {
359359
allowed_to_pull_identities = ["arn:aws:iam::992382665735:role/launch20251017122840582600000005"]
360360
}
361361

362-
module "private_ecr_github_actions_upload_credentials_launch_system" {
363-
source = "./private-ecr-upload-credentials"
364-
365-
iam_user_name = "github_actions_upload_user_launch_system"
366-
ecr_repository_name = module.launch_system.repository_name
367-
github_organisation = local.github_organisation
368-
github_repository_name = "launch-system"
369-
}
370-
371362
module "launch_api" {
372363
source = "./private-ecr-repo"
373364

@@ -389,7 +380,7 @@ module "launch_executor" {
389380
allowed_to_pull_identities = ["arn:aws:iam::009203151042:role/launch20251017061000092500000003"]
390381
}
391382

392-
module "private_ecr_github_actions_upload_credentials_launch_executor" {
383+
module "private_ecr_github_actions_upload_credentials_launch_system_family" {
393384
source = "./private-ecr-upload-credentials"
394385

395386
iam_user_name = "github_actions_upload_user_launch_containers"

outputs.tf

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -129,22 +129,13 @@ output "private_ecr_github_actions_upload_credentials_obi_notebook_image_secret_
129129
}
130130

131131
output "private_ecr_github_actions_upload_credentials_obi_launch_system_access_key_id" {
132-
value = module.private_ecr_github_actions_upload_credentials_launch_system.privateecr_upload_access_key_id
132+
value = module.private_ecr_github_actions_upload_credentials_launch_system_family.privateecr_upload_access_key_id
133133
sensitive = true
134134
}
135135

136136
output "private_ecr_github_actions_upload_credentials_obi_launch_system_secret_access_key" {
137-
value = module.private_ecr_github_actions_upload_credentials_launch_system.privateecr_upload_secret_access_key
138-
sensitive = true
139-
}
140-
141-
output "private_ecr_github_actions_upload_credentials_obi_launch_executor_access_key_id" {
142-
value = module.private_ecr_github_actions_upload_credentials_launch_executor.privateecr_upload_access_key_id
143-
sensitive = true
144-
}
145-
146-
output "private_ecr_github_actions_upload_credentials_obi_launch_executor_secret_access_key" {
147-
value = module.private_ecr_github_actions_upload_credentials_launch_executor.privateecr_upload_secret_access_key
137+
value = module.private_ecr_github_actions_upload_credentials_launch_system_family.privateecr_upload_secret_access_key
138+
# value = module.private_ecr_github_actions_upload_credentials_launch_system.privateecr_upload_secret_access_key
148139
sensitive = true
149140
}
150141

0 commit comments

Comments
 (0)