Skip to content

Libs download issues on VS #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prisonerjohn opened this issue Oct 14, 2016 · 5 comments
Closed

Libs download issues on VS #5311

prisonerjohn opened this issue Oct 14, 2016 · 5 comments

Comments

@prisonerjohn
Copy link
Contributor

I think there's an issue with the new libs download script (referencing #5299)

In Visual Studio, I just tried using the .ps1 script to download the libs and I think it messed up with assimp and opencv.

The following is my ofxOpenCv folder. There's a bunch of assimp stuff in there, and there are no opencv header files.
capture

The following is my libs folder. I see ippicv in here but no assimp or opencv. Is this where these are all supposed to go?
capture-2

If I'm doing this wrong, what's the procedure for getting these files in the right place?

@prisonerjohn
Copy link
Contributor Author

Digging into the scripts I'm seeing some issues:

https://github.com/openframeworks/openFrameworks/blob/master/scripts/vs/download_libs.ps1#L54-L55

  • assimp getting copied inside ofxOpenCv
  • no mention of ippicv

https://github.com/openframeworks/openFrameworks/blob/master/scripts/dev/download_libs.sh#L174-L177

  • assimp getting copied inside ofxOpenCv

And I don't see any includes anywhere in there (or even in the zips at http://ci.openframeworks.cc/libs/).

I can take a stab at fixing the VS scripts if you tell me where stuff is supposed to go.

@arturoc
Copy link
Member

arturoc commented Oct 18, 2016

this should be fixed now if you can check again?

@prisonerjohn
Copy link
Contributor Author

The files for different architectures are going in different places. I'm seeing similar patterns for both ofxOpenCv and ofxAssimpModelLoader.

Win32 does openframeworks\addons\ofxOpenCv\libs\lib\vs\$(Platform)\$(Configuration)
capture-win32

x64 does openframeworks\addons\ofxOpenCv\libs\opencv\lib\vs\$(Configuration)
capture-x64

I believe it should be openframeworks\addons\ofxOpenCv\libs\opencv\lib\vs\$(Platform)\$(Configuration) for both cases.

@arturoc
Copy link
Member

arturoc commented Oct 19, 2016

yeah that's not correct i'll take a look tomorrow

@arturoc
Copy link
Member

arturoc commented Nov 23, 2016

i think this should be fixed already, going to close it. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants