Merge branch 'main' into add-a11y

Author: thomas-kl1

README.md

@@ -46,6 +46,17 @@ This module is Hyvä-Ready!
 This module render server-sided product breadcrumbs so it's visible to any robot without requiring any js loads and process.  
 Can you still enable the js breadcrumbs so your user can see natural breadcrumbs following their navigation.
 
+## Settings
+
+The settings are available at:
+
+`Stores > Configuration > Catalog > Catalog > Search Engine Optimization`
+
+- Render Product Breadcrumbs from Server-Side
+- Override Product Breadcrumbs on Client-Side
+- Product Breadcrumbs Strategy
+- Product Breadcrumbs Excluded Categories
+
 ## Documentation
 
 - Toggle server-side product breadcrumbs rendering.

view/frontend/templates/hyva/product/breadcrumbs.phtml

@@ -16,17 +16,18 @@ use Opengento\ProductBreadcrumbs\ViewModel\Product\Breadcrumbs as BreadcrumbsCon
 
 /** @var BreadcrumbsConfig $config */
 $config = $viewModels->require(BreadcrumbsConfig::class);
+$isClientSideRendered = !$config->isServerSideRendered() || $config->isClientSideOverrideAllowed();
 ?>
-<div id="product_breadcrumbs" aria-label="Breadcrumb" role="navigation" x-init="generateProductBreadcrumbsOnProductPage()">
+<div id="product_breadcrumbs" aria-label="<?= $escaper->escapeHtmlAttr(__('Breadcrumb')) ?>" role="navigation"<?= $isClientSideRendered ? ' x-init="generateProductBreadcrumbsOnProductPage()"' : '' ?>>
 <?php if ($config->isServerSideRendered()): ?>
     <?= $block->fetchView($block->getTemplateFile('Magento_Theme::html/breadcrumbs.phtml')) ?>
 <?php endif; ?>
 </div>
-<script>
-    function generateProductBreadcrumbsOnProductPage() {
-<?php if (!$config->isServerSideRendered() || $config->isClientSideOverrideAllowed()): ?>
-    <?php $breadcrumbsTemplate = '<div id="product_breadcrumbs" aria-label="Breadcrumb" role="navigation">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
-    hyva.replaceDomElement('#product_breadcrumbs', '<?= $escaper->escapeJs($breadcrumbsTemplate) ?>');
+<?php if ($isClientSideRendered): ?>
+    <script>
+        function generateProductBreadcrumbsOnProductPage() {
+            <?php $breadcrumbsTemplate = '<div id="product_breadcrumbs" aria-label="' . $escaper->escapeHtmlAttr(__('Breadcrumb')) . '" role="navigation">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
+            hyva.replaceDomElement('#product_breadcrumbs', '<?= $escaper->escapeJs($breadcrumbsTemplate) ?>');
+        }
+    </script>
 <?php endif; ?>
-    }
-</script>

view/frontend/templates/product/breadcrumbs.phtml

@@ -24,6 +24,14 @@ $config = $block->getData('breadcrumbsConfig');
     $catalogHelper = $this->helper(CatalogHelper::class);
     /** @var BreadcrumbsBlock $breadcrumbs */
     $breadcrumbs = $block->getLayout()->createBlock(BreadcrumbsBlock::class);
+    $breadcrumbs->addCrumb(
+        'home',
+        [
+            'label' => __('Home'),
+            'title' => __('Go to Home Page'),
+            'link' => $block->getBaseUrl()
+        ]
+    );
     foreach ($catalogHelper->getBreadcrumbPath() as $name => $crumb) {
         $breadcrumbs->addCrumb($name, $crumb);
     }