Skip to content

Commit 1bd1e05

Browse files
[CI] Bump chromedriver to 102 (#1811) (#1859)
GitHub env runs on Chrome 102. This is done to get the CI working again on 1.x however there is a follow-up issue here: #1746 However, there's an issue with Node existing on an a user that the GitHub CI doesn't have permissions too. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e27b40b) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
1 parent acc71ab commit 1bd1e05

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

.github/workflows/pr_check_workflow.yml

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,6 @@ jobs:
9595

9696
- run: echo Unit tests completed unsuccessfully. However, unit tests are inconsistent on the CI so please verify locally with `yarn test:jest`.
9797
if: steps.unit_tests_results.outputs.unit_tests_results != 'success' && steps.unit-tests.outcome != 'success'
98-
99-
# TODO: This gets rejected, we need approval to add this
100-
# - name: Add comment if unit tests did not succeed
101-
# if: steps.unit_tests_results.outputs.unit_tests_results != 'success' && steps.unit-tests.outcome != 'success'
102-
# uses: actions/github-script@v5
103-
# with:
104-
# github-token: ${{ secrets.GITHUB_TOKEN }}
105-
# script: |
106-
# github.rest.issues.createComment({
107-
# issue_number: context.issue.number,
108-
# owner: context.repo.owner,
109-
# repo: context.repo.repo,
110-
# body: 'Unit tests completed unsuccessfully. However, unit tests are inconsistent on the CI so please verify locally with `yarn test:jest`.'
111-
# })
11298

11399
- name: Run integration tests
114100
if: steps.integration_tests_results.outputs.integration_tests_results != 'success'
@@ -190,7 +176,7 @@ jobs:
190176
# github virtual env is the latest chrome
191177
- name: Setup chromedriver
192178
if: steps.ftr_tests_results.outputs.ftr_tests_results != 'success'
193-
run: yarn add --dev chromedriver@100.0.0
179+
run: yarn add --dev chromedriver@102.0.0
194180

195181
- name: Run bootstrap
196182
if: steps.ftr_tests_results.outputs.ftr_tests_results != 'success'

0 commit comments

Comments
 (0)