Skip to content

Commit c39d2b4

Browse files
authored
[1.1] Fix yarn build docs and update test (#844)
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: #836 Backport PR: #840 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
1 parent 3e6d39e commit c39d2b4

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

DEVELOPER_GUIDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ access it.
6666

6767
### Building the artifacts
6868

69-
To build the archives for each platform, run the following:
69+
To build the artifacts for all supported platforms, run the following:
7070

7171
```
7272
yarn build --skip-os-packages

src/dev/build/args.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ it('build dist for current platform, without packages, by default', () => {
6767
`);
6868
});
6969

70-
it('build dist for linux x64 platform, without packages, if --linux-x64 is passed', () => {
71-
expect(readCliArgs(['node', 'scripts/build-platform'])).toMatchInlineSnapshot(`
70+
it('build dist for linux x64 platform, without packages, if --linux is passed', () => {
71+
expect(readCliArgs(['node', 'scripts/build-platform', '--linux'])).toMatchInlineSnapshot(`
7272
Object {
7373
"buildOptions": Object {
7474
"createArchives": true,
@@ -81,7 +81,7 @@ it('build dist for linux x64 platform, without packages, if --linux-x64 is passe
8181
"targetAllPlatforms": false,
8282
"targetPlatforms": Object {
8383
"darwin": false,
84-
"linux": false,
84+
"linux": true,
8585
"linuxArm": false,
8686
},
8787
"versionQualifier": "",
@@ -93,8 +93,8 @@ it('build dist for linux x64 platform, without packages, if --linux-x64 is passe
9393
`);
9494
});
9595

96-
it('build dist for linux x64 platform, without packages, if --linux-arm64 is passed', () => {
97-
expect(readCliArgs(['node', 'scripts/build-platform'])).toMatchInlineSnapshot(`
96+
it('build dist for linux arm64 platform, without packages, if --linux-arm is passed', () => {
97+
expect(readCliArgs(['node', 'scripts/build-platform', '--linux-arm'])).toMatchInlineSnapshot(`
9898
Object {
9999
"buildOptions": Object {
100100
"createArchives": true,
@@ -108,7 +108,7 @@ it('build dist for linux x64 platform, without packages, if --linux-arm64 is pas
108108
"targetPlatforms": Object {
109109
"darwin": false,
110110
"linux": false,
111-
"linuxArm": false,
111+
"linuxArm": true,
112112
},
113113
"versionQualifier": "",
114114
},
@@ -119,8 +119,8 @@ it('build dist for linux x64 platform, without packages, if --linux-arm64 is pas
119119
`);
120120
});
121121

122-
it('build dist for linux x64 platform, without packages, if --darwin-x64 is passed', () => {
123-
expect(readCliArgs(['node', 'scripts/build-platform'])).toMatchInlineSnapshot(`
122+
it('build dist for darwin x64 platform, without packages, if --darwin is passed', () => {
123+
expect(readCliArgs(['node', 'scripts/build-platform', '--darwin'])).toMatchInlineSnapshot(`
124124
Object {
125125
"buildOptions": Object {
126126
"createArchives": true,
@@ -132,7 +132,7 @@ it('build dist for linux x64 platform, without packages, if --darwin-x64 is pass
132132
"isRelease": false,
133133
"targetAllPlatforms": false,
134134
"targetPlatforms": Object {
135-
"darwin": false,
135+
"darwin": true,
136136
"linux": false,
137137
"linuxArm": false,
138138
},

src/dev/build/cli.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ if (showHelp) {
5555
--skip-archives {dim Don't produce tar/zip archives}
5656
--skip-os-packages {dim Don't produce rpm/deb/docker packages}
5757
--all-platforms {dim Produce archives for all platforms, not just this one}
58-
--linux-x64 {dim Produce archives for only linux x64 platform}
59-
--linux-arm64 {dim Produce archives for only linux arm64 platform}
60-
--darwin-x64 {dim Produce archives for only darwin x64 platform}
58+
--linux {dim Produce archives for only linux x64 platform}
59+
--linux-arm {dim Produce archives for only linux arm64 platform}
60+
--darwin {dim Produce archives for only darwin x64 platform}
6161
--rpm {dim Only build the rpm package}
6262
--deb {dim Only build the deb package}
6363
--docker {dim Only build the docker image}

0 commit comments

Comments
 (0)