re-render alerts table on comment setting update (#1085) (#1087)

opensearch-trigger-bot[bot] · github-actions[bot] · web-flow · commit 3edb13d43042 · 2024-09-10T16:52:48.000-07:00
(cherry picked from commit 98fa437) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
diff --git a/public/components/Flyout/flyouts/components/AlertsDashboardFlyoutComponent.js b/public/components/Flyout/flyouts/components/AlertsDashboardFlyoutComponent.js
@@ -121,7 +121,7 @@ export default class AlertsDashboardFlyoutComponent extends Component {
     });
   }
 
-  componentDidUpdate(prevProps, prevState) {
+  componentDidUpdate(_prevProps, prevState) {
     const prevQuery = getQueryObjectFromState(prevState);
     const currQuery = getQueryObjectFromState(this.state);
     if (!_.isEqual(prevQuery, currQuery)) {
@@ -146,10 +146,11 @@ export default class AlertsDashboardFlyoutComponent extends Component {
         monitorIds
       );
     }
-    const { monitorType } = this.state;
+    const { monitorType, commentsEnabled, tabId } = this.state;
     if (
-      [MONITOR_TYPE.DOC_LEVEL, MONITOR_TYPE.COMPOSITE_LEVEL].includes(monitorType) &&
-      !_.isEqual(prevState.selectedItems, this.state.selectedItems)
+      ([MONITOR_TYPE.DOC_LEVEL, MONITOR_TYPE.COMPOSITE_LEVEL].includes(monitorType) &&
+        !_.isEqual(prevState.selectedItems, this.state.selectedItems)) ||
+      (tabId === TABLE_TAB_IDS.ALERTS.id && commentsEnabled !== prevState.commentsEnabled)
     )
       this.setState({ tabContent: this.renderAlertsTable() });
   }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ export default class AlertsDashboardFlyoutComponent extends Component {`
`121`	`121`	`});`
`122`	`122`	`}`
`123`	`123`
`124`		`- componentDidUpdate(prevProps, prevState) {`
	`124`	`+ componentDidUpdate(_prevProps, prevState) {`
`125`	`125`	`const prevQuery = getQueryObjectFromState(prevState);`
`126`	`126`	`const currQuery = getQueryObjectFromState(this.state);`
`127`	`127`	`if (!_.isEqual(prevQuery, currQuery)) {`
`@@ -146,10 +146,11 @@ export default class AlertsDashboardFlyoutComponent extends Component {`
`146`	`146`	`monitorIds`
`147`	`147`	`);`
`148`	`148`	`}`
`149`		`- const { monitorType } = this.state;`
	`149`	`+ const { monitorType, commentsEnabled, tabId } = this.state;`
`150`	`150`	`if (`
`151`		`- [MONITOR_TYPE.DOC_LEVEL, MONITOR_TYPE.COMPOSITE_LEVEL].includes(monitorType) &&`
`152`		`- !_.isEqual(prevState.selectedItems, this.state.selectedItems)`
	`151`	`+ ([MONITOR_TYPE.DOC_LEVEL, MONITOR_TYPE.COMPOSITE_LEVEL].includes(monitorType) &&`
	`152`	`+ !_.isEqual(prevState.selectedItems, this.state.selectedItems)) \|\|`
	`153`	`+ (tabId === TABLE_TAB_IDS.ALERTS.id && commentsEnabled !== prevState.commentsEnabled)`
`153`	`154`	`)`
`154`	`155`	`this.setState({ tabContent: this.renderAlertsTable() });`
`155`	`156`	`}`