Skip to content

Commit 62eb2d3

Browse files
author
Per Goncalves da Silva
committed
Fix lint
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
1 parent ceaced8 commit 62eb2d3

File tree

10 files changed

+26
-34
lines changed

10 files changed

+26
-34
lines changed

test/test-operator/v1.0.0/cmd/main.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@ import (
2121
"flag"
2222
"os"
2323
"path/filepath"
24-
"sigs.k8s.io/controller-runtime/pkg/cache"
25-
26-
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
27-
// to ensure that exec-entrypoint and run can make use of them.
28-
_ "k8s.io/client-go/plugin/pkg/client/auth"
2924

3025
"k8s.io/apimachinery/pkg/runtime"
3126
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
3227
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
28+
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
29+
// to ensure that exec-entrypoint and run can make use of them.
30+
_ "k8s.io/client-go/plugin/pkg/client/auth"
3331
ctrl "sigs.k8s.io/controller-runtime"
32+
"sigs.k8s.io/controller-runtime/pkg/cache"
3433
"sigs.k8s.io/controller-runtime/pkg/certwatcher"
3534
"sigs.k8s.io/controller-runtime/pkg/healthz"
3635
"sigs.k8s.io/controller-runtime/pkg/log/zap"
@@ -40,7 +39,6 @@ import (
4039

4140
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
4241
"github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/internal/controller"
43-
// +kubebuilder:scaffold:imports
4442
)
4543

4644
var (

test/test-operator/v1.0.0/internal/controller/suite_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import (
3333
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3434

3535
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
36-
// +kubebuilder:scaffold:imports
3736
)
3837

3938
// These tests use Ginkgo (BDD-style Go testing framework). Refer to

test/test-operator/v1.0.0/internal/controller/testoperator_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@ import (
2121
"fmt"
2222

2323
"k8s.io/apimachinery/pkg/api/equality"
24-
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
25-
2624
"k8s.io/apimachinery/pkg/runtime"
2725
ctrl "sigs.k8s.io/controller-runtime"
2826
"sigs.k8s.io/controller-runtime/pkg/client"
27+
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
2928
"sigs.k8s.io/controller-runtime/pkg/log"
3029

3130
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"

test/test-operator/v1.0.0/internal/controller/testoperator_controller_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,15 @@ package controller
1919
import (
2020
"context"
2121

22-
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
23-
2422
. "github.com/onsi/ginkgo/v2"
2523
. "github.com/onsi/gomega"
24+
2625
"k8s.io/apimachinery/pkg/api/errors"
26+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2727
"k8s.io/apimachinery/pkg/types"
28+
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
2829
"sigs.k8s.io/controller-runtime/pkg/reconcile"
2930

30-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
31-
3231
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
3332
)
3433

test/test-operator/v2.0.0/cmd/main.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@ import (
2121
"flag"
2222
"os"
2323
"path/filepath"
24-
"sigs.k8s.io/controller-runtime/pkg/cache"
25-
26-
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
27-
// to ensure that exec-entrypoint and run can make use of them.
28-
_ "k8s.io/client-go/plugin/pkg/client/auth"
2924

3025
"k8s.io/apimachinery/pkg/runtime"
3126
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
3227
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
28+
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
29+
// to ensure that exec-entrypoint and run can make use of them.
30+
_ "k8s.io/client-go/plugin/pkg/client/auth"
3331
ctrl "sigs.k8s.io/controller-runtime"
32+
"sigs.k8s.io/controller-runtime/pkg/cache"
3433
"sigs.k8s.io/controller-runtime/pkg/certwatcher"
3534
"sigs.k8s.io/controller-runtime/pkg/healthz"
3635
"sigs.k8s.io/controller-runtime/pkg/log/zap"
@@ -42,7 +41,6 @@ import (
4241
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
4342
"github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/internal/controller"
4443
testolmwebhook "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/internal/webhook"
45-
// +kubebuilder:scaffold:imports
4644
)
4745

4846
var (

test/test-operator/v2.0.0/internal/controller/suite_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ package controller
1818

1919
import (
2020
"context"
21-
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
22-
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
2321
"os"
2422
"path/filepath"
2523
"testing"
@@ -33,7 +31,9 @@ import (
3331
"sigs.k8s.io/controller-runtime/pkg/envtest"
3432
logf "sigs.k8s.io/controller-runtime/pkg/log"
3533
"sigs.k8s.io/controller-runtime/pkg/log/zap"
36-
// +kubebuilder:scaffold:imports
34+
35+
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
36+
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
3737
)
3838

3939
// These tests use Ginkgo (BDD-style Go testing framework). Refer to

test/test-operator/v2.0.0/internal/controller/testoperator_controller.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,15 @@ import (
2020
"context"
2121
"fmt"
2222

23-
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
24-
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
25-
2623
"k8s.io/apimachinery/pkg/api/equality"
27-
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
28-
2924
"k8s.io/apimachinery/pkg/runtime"
3025
ctrl "sigs.k8s.io/controller-runtime"
3126
"sigs.k8s.io/controller-runtime/pkg/client"
27+
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
3228
"sigs.k8s.io/controller-runtime/pkg/log"
29+
30+
testolmv1 "github.com/operator-framework/operator-controller/test/test-operator/v1.0.0/api/v1"
31+
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
3332
)
3433

3534
const (

test/test-operator/v2.0.0/internal/controller/testoperator_controller_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ package controller
1818

1919
import (
2020
"context"
21-
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
2221

2322
. "github.com/onsi/ginkgo/v2"
2423
. "github.com/onsi/gomega"
24+
2525
"k8s.io/apimachinery/pkg/api/errors"
26+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/apimachinery/pkg/types"
28+
crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
2729
"sigs.k8s.io/controller-runtime/pkg/reconcile"
2830

29-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
30-
3131
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
3232
)
3333

test/test-operator/v2.0.0/internal/webhook/testoperator_webhook.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ package webhook
1919
import (
2020
"context"
2121
"fmt"
22-
apierrors "k8s.io/apimachinery/pkg/api/errors"
23-
"k8s.io/apimachinery/pkg/runtime/schema"
24-
"k8s.io/apimachinery/pkg/util/validation/field"
2522
"strings"
2623

24+
apierrors "k8s.io/apimachinery/pkg/api/errors"
2725
"k8s.io/apimachinery/pkg/runtime"
26+
"k8s.io/apimachinery/pkg/runtime/schema"
27+
"k8s.io/apimachinery/pkg/util/validation/field"
2828
ctrl "sigs.k8s.io/controller-runtime"
2929
logf "sigs.k8s.io/controller-runtime/pkg/log"
3030
"sigs.k8s.io/controller-runtime/pkg/webhook"

test/test-operator/v2.0.0/internal/webhook/webhook_suite_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ import (
4040
"sigs.k8s.io/controller-runtime/pkg/webhook"
4141

4242
testolmv2 "github.com/operator-framework/operator-controller/test/test-operator/v2.0.0/api/v2"
43-
// +kubebuilder:scaffold:imports
4443
)
4544

4645
// These tests use Ginkgo (BDD-style Go testing framework). Refer to
@@ -124,6 +123,7 @@ var _ = BeforeSuite(func() {
124123
dialer := &net.Dialer{Timeout: time.Second}
125124
addrPort := fmt.Sprintf("%s:%d", webhookInstallOptions.LocalServingHost, webhookInstallOptions.LocalServingPort)
126125
Eventually(func() error {
126+
// nolint:gosec
127127
conn, err := tls.DialWithDialer(dialer, "tcp", addrPort, &tls.Config{InsecureSkipVerify: true})
128128
if err != nil {
129129
return err

0 commit comments

Comments
 (0)