Release OpenProject 12.2.4

Author: oliverguenther

Gemfile.lock

@@ -665,7 +665,7 @@ GEM
     octokit (4.25.1)
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
-    oj (3.13.16)
+    oj (3.13.21)
     okcomputer (1.18.4)
     omniauth-saml (1.10.3)
       omniauth (~> 1.3, >= 1.3.2)

config/locales/crowdin/ar.yml

@@ -72,10 +72,10 @@ ar:
       required_for_feature: "This feature is only available with an active Enterprise Edition support token."
       enterprise_link: "For more information, click here."
       start_trial: 'Start free trial'
-      book_now: 'Book now'
+      book_now: 'احجز الآن'
       get_quote: 'Get a quote'
       buttons:
-        upgrade: "Upgrade now"
+        upgrade: "الترقية الآن"
         contact: "Contact us for a demo"
       enterprise_info_html: "is an Enterprise <strong class='icon-medal'></strong> feature."
       upgrade_info: "Please upgrade to a paid plan to activate and start using it in your team."

config/locales/crowdin/hu.yml

@@ -62,7 +62,7 @@ tr:
     button_confirm: "Onaylamak"
     button_continue: "Devam et"
     button_copy: "Kopyalamak"
-    button_copy_to_other_project: "Copy to other project"
+    button_copy_to_other_project: "Başka bir projeye kopyala"
     button_custom-fields: "Özel Alanlar"
     button_delete: "silmek"
     button_delete_watcher: "Takipçi sil"
@@ -520,7 +520,7 @@ tr:
           timeline_button: 'You can activate the <b>Gantt chart</b> view to create a timeline for your project.'
           timeline: 'Here you can <b>edit your project plan</b>, create new work packages, such as tasks, milestones, phases, and more, as well as <b>add dependencies</b>. All team members can see and update the latest plan at any time.'
         team_planner:
-          overview: 'The team planner lets you visually assign tasks to team members and get an overview of who is working on what.'
+          overview: 'Takım planlayıcı, takım üyelerine görsel olarak görevler atamanıza ve kimin ne üzerinde çalıştığına dair bir genel bakış elde etmenize olanak tanır.'
           calendar: 'The weekly or biweekly planning board displays all work packages assigned to your team members.'
           add_assignee: 'To get started, add assignees to the team planner.'
           add_existing: 'Search for existing work packages and drag them to the team planner to instantly assign them to a team member and define start and end dates.'

config/locales/crowdin/js-tr.yml

@@ -0,0 +1,31 @@
+class FixInvalidJournals < ActiveRecord::Migration[7.0]
+  def up
+    get_broken_journals.each do |journable_type, relation|
+      next unless relation.any?
+
+      # rubocop:disable Rails/Output
+      puts "Cleaning up broken journals on #{journable_type}"
+      # rubocop:enable Rails/Output
+      relation.destroy_all
+    end
+  end
+
+  def down
+    # nothing to do
+  end
+
+  def get_broken_journals
+    Journal
+      .pluck('DISTINCT(journable_type)')
+      .compact
+      .to_h do |journable_type|
+      journal_class = journable_type.constantize.journal_class
+
+      relation = Journal
+        .where(journable_type:)
+        .where.not(data_type: journal_class.to_s)
+
+      [journable_type, relation]
+    end
+  end
+end

db/migrate/20220818074150_fix_invalid_journals.rb

@@ -40,4 +40,4 @@ It is sometimes good to have backups on other locations (e.g. local vs cloud). Y
 1. The Token must be already generated and stored in a secure keystore
 2. The API Key must be known and stored in a secure keystore
 
-You could use our [example bash script](/script/backup-via-apiv3.sh) and integrate it in your crond for running it daily.
+You could use our [example bash script](./script/backup-via-apiv3.sh) and integrate it in your crond for running it daily.

docs/enterprise-guide/enterprise-cloud-guide/backups/README.md

@@ -11,7 +11,7 @@ Our Premium and Corporate Enterprise on-premises support plans include installat
 
 ## Support Data Collector
 
-Please run [our script](/script/op-support-data.sh) and send us the complete terminal output prior to the on-premise installation.
+Please run [our script](./script/op-support-data.sh) and send us the complete terminal output prior to the on-premise installation.
 
 The script should run once on the OpenProject on-premises host with or without OpenProject installed
  It will ask you some questions that are needed to be answered interactively.

docs/enterprise-guide/enterprise-on-premises-guide/support/installation-support/README.md

@@ -77,7 +77,7 @@ Please be aware that only those variables shall be edited which are documented a
 
 #### BIM Edition
 
-In order to install or change to BIM inside a Docker environment, please navigate to the [Docker](../installation-and-operations/changing-to-bim-edition/#docker) paragraph at the [Changing to BIM Edition](../installation-and-operations/changing-to-bim-edition) documentation. 
+In order to install or change to BIM inside a Docker environment, please navigate to the [Docker](../../changing-to-bim-edition/#docker) paragraph at the [Changing to BIM Edition](../../changing-to-bim-edition/) documentation. 
 
 ### Disabling services in the docker-compose file
 

docs/installation-and-operations/installation/docker/README.md

@@ -13,7 +13,12 @@ Release date: 2022-09-12
 We released [OpenProject 12.2.3](https://community.openproject.com/versions/1598).
 The release contains several bug fixes and we recommend updating to the newest version.
 
+### Fixed: Installing custom plugins in packaged installations
+
+Newer bundler versions would prevent custom plugins being installed in packaged installation.
+This has been fixed in this released version. For more information, please see [#44058](https://community.openproject.com/wp/44058)
+
 <!--more-->
 #### Bug fixes and changes
 
-- Changed: Add meaningful tooltips to the most essential actions \[[#43299](https://community.openproject.com/wp/43299)\]
+- Fixed: RPM/DEB installation fails with a custom gemfile \[[#44058](https://community.openproject.com/wp/44058)\]

docs/release-notes/12-2-3/README.md

@@ -0,0 +1,29 @@
+---
+title: OpenProject 12.2.4
+sidebar_navigation:
+    title: 12.2.4
+release_version: 12.2.4
+release_date: 2022-09-15
+---
+
+# OpenProject 12.2.4
+
+Release date: 2022-09-15
+
+We released [OpenProject 12.2.4](https://community.openproject.com/versions/1599).
+The release contains several bug fixes and we recommend updating to the newest version.
+
+<!--more-->
+#### Bug fixes and changes
+
+- Fixed: Remaining hours sum not well formed \[[#43833](https://community.openproject.com/wp/43833)\]
+- Fixed: Destroy journals with invalid data_type associations \[[#44132](https://community.openproject.com/wp/44132)\]
+- Fixed: Internal error / Illegal instruction error \[[#44155](https://community.openproject.com/wp/44155)\]
+- Fixed: Dragging images to CKEditor on Grid custom texts not working with direct upload \[[#44156](https://community.openproject.com/wp/44156)\]
+
+#### Contributions
+A big thanks to community members for reporting bugs and helping us identifying and providing fixes.
+
+Special thanks for reporting and finding bugs go to
+
+Nico Aymet

docs/release-notes/12-2-4/README.md

@@ -14,6 +14,13 @@ Stay up to date and get an overview of the new features included in the releases
 <!--- New release notes are generated below. Do not remove comment. -->
 <!--- RELEASE MARKER -->
 
+## 12.2.4
+
+Release date: 2022-09-15
+
+[Release Notes](12-2-4/)
+
+
 ## 12.2.3
 
 Release date: 2022-09-12

docs/release-notes/README.md

@@ -192,8 +192,7 @@ In the details view of the work package: Click on **More** (button with three do
 
 ### Can I group tasks into folders?
 
-There are no folders for work packages. I suggest either setting all work packages belonging together as children of the same parent work package (e.g. a Phase) or to create multiple projects for different topics. Alternatively you could use the [work package categories](../../projects/project-settings/work-package-categories) or a custom field to group work packages.   You can also indent hierarchy for for tasks to associate it with another work package like a phase, then they are relatete to the Pahase in the gantt chart.
-
+There are no folders for work packages. To group work packages, such as tasks, you can use the [filter and grouping options](../work-package-table-configuration/#work-package-table-configuration) and [save the filters](../work-package-table-configuration/#save-work-package-views). You can also define all related work packages as children of the same parent work package (e.g. a phase). you can indent the hierarchy for work packages in the work packages list (with a right mouse click -> *Indent hierarchy*) to add them as children to another work package, for example a phase. This will then also be displayed in the Gantt chart. Alternatively, you can use the [work package categories](../../projects/project-settings/work-package-categories/#manage-work-package-categories) or a custom field to filter and group work packages. Also, you can create multiple projects to group different topics.
 
 ## Custom fields
 

docs/user-guide/work-packages/work-packages-faq/README.md

@@ -83,6 +83,9 @@ module.exports = {
         // no param reassignment is a pain when trying to set props on elements
         "no-param-reassign": "off",
 
+        // destructuring doesn't always look better, only when object/array destructuring
+        "prefer-destructuring": "off",
+
         // No void at all collides with `@typescript-eslint/no-floating-promises` which wants us to handle each promise.
         // Until we do that, `void` is a good way to explicitly mark unhandled promises. 
         "no-void": ["error", { allowAsStatement: true }],

frontend/.eslintrc.js

@@ -75,6 +75,7 @@ export function initializeCoreDisplayFields(displayFieldService:DisplayFieldServ
       .addFieldType(MultipleUserFieldModule, 'users', ['[]User'])
       .addFieldType(FormattableDisplayField, 'formattable', ['Formattable'])
       .addFieldType(DaysDurationDisplayField, 'duration', ['duration'])
+      .addFieldType(HoursDurationDisplayField, 'remainingTime', ['remainingTime'])
       .addFieldType(EstimatedTimeDisplayField, 'estimatedTime', ['estimatedTime'])
       .addFieldType(DateDisplayField, 'date', ['Date'])
       .addFieldType(DateTimeDisplayField, 'datetime', ['DateTime'])
@@ -88,7 +89,6 @@ export function initializeCoreDisplayFields(displayFieldService:DisplayFieldServ
       .addSpecificFieldType('WorkPackage', WorkPackageIdDisplayField, 'id', ['id'])
       .addSpecificFieldType('WorkPackage', WorkPackageSpentTimeDisplayField, 'spentTime', ['spentTime'])
       .addSpecificFieldType('WorkPackage', CombinedDateDisplayField, 'combinedDate', ['combinedDate'])
-      .addSpecificFieldType('WorkPackage', HoursDurationDisplayField, 'remainingTime', ['remainingTime'])
       .addSpecificFieldType('TimeEntry', PlainFormattableDisplayField, 'comment', ['comment'])
       .addSpecificFieldType('Project', ProjectStatusDisplayField, 'status', ['status'])
       .addSpecificFieldType('TimeEntry', WorkPackageDisplayField, 'work_package', ['workPackage']);

frontend/src/app/shared/components/fields/display/display-field.initializer.ts

@@ -10,6 +10,7 @@ import { SchemaCacheService } from 'core-app/core/schemas/schema-cache.service';
 import { UploadFile } from 'core-app/core/file-upload/op-file-upload.service';
 import { ICKEditorContext } from 'core-app/shared/components/editor/components/ckeditor/ckeditor.types';
 import { HalResource } from 'core-app/features/hal/resources/hal-resource';
+import { GridResource } from 'core-app/features/hal/resources/grid-resource';
 
 @Injectable()
 export class CustomTextEditFieldService extends EditFieldHandler {
@@ -138,21 +139,27 @@ export class CustomTextEditFieldService extends EditFieldHandler {
    */
   private initializeChangeset(value:GridWidgetResource) {
     const schemaHref = 'customtext-schema';
-    const resourceSource = {
+    const grid:GridResource = value.grid;
+    const resourceSource:HalSource = {
       text: value.options.text,
       getEditorContext: () => ({
         type: 'full',
         macros: 'resource',
       } as ICKEditorContext),
       canAddAttachments: value.grid.canAddAttachments as boolean,
       _links: {
-        attachments: (value.grid as HalResource).attachments as { href?:string },
+        attachments: grid.attachments as { href?:string },
         schema: {
           href: schemaHref,
         },
       },
     };
 
+    if (grid.prepareAttachment as { href?:string }) {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment,@typescript-eslint/no-unsafe-member-access
+      resourceSource._links.prepareAttachment = grid.prepareAttachment;
+    }
+
     const resource = this.halResource.createHalResource(resourceSource, true);
 
     const schemaSource = {

frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts

@@ -33,7 +33,7 @@ module OpenProject
   module VERSION # :nodoc:
     MAJOR = 12
     MINOR = 2
-    PATCH = 3
+    PATCH = 4
 
     class << self
       # Used by semver to define the special version (if any).

lib/open_project/version.rb

@@ -55,7 +55,7 @@
            status:
   end
 
-  it 'is can set and edit the remaining time in hours (Regression #43549)' do
+  it 'can set and edit the remaining time in hours (Regression #43549)' do
     wp_page = Pages::FullWorkPackage.new(work_package)
 
     wp_page.visit!
@@ -65,10 +65,31 @@
 
     wp_page.update_attributes remainingTime: '125' # rubocop:disable Rails/ActiveRecordAliases
 
-    wp_page.expect_attributes remainingTime: '125'
+    wp_page.expect_attributes remainingTime: '125 h'
 
     work_package.reload
 
     expect(work_package.remaining_hours).to eq 125.0
   end
+
+  it 'displays the remaining time sum properly in hours (Regression #43833)' do
+    work_package
+    wp_table_page = Pages::WorkPackagesTable.new(project)
+
+    query_props = JSON.dump(c: %w(id subject remainingTime),
+                            s: true)
+
+    wp_table_page.visit_with_params("query_props=#{query_props}")
+
+    wp_table_page.expect_work_package_with_attributes work_package, remainingTime: '-'
+
+    wp_table_page.update_work_package_attributes work_package, remainingTime: '125'
+
+    wp_table_page.expect_work_package_with_attributes work_package, remainingTime: '125 h'
+
+    wp_table_page.expect_sums_row_with_attributes remainingTime: '125 h'
+
+    work_package.reload
+    expect(work_package.remaining_hours).to eq 125.0
+  end
 end

modules/backlogs/spec/features/work_packages/remaining_time_spec.rb

@@ -14,7 +14,6 @@ lv:
     exceptions:
       file_invalid: "BCF file invalid"
     x_bcf_issues:
-      zero: 'No BCF issues'
       one: 'One BCF issue'
       other: '%{count} BCF issues'
     bcf_xml:

modules/bim/config/locales/crowdin/lv.yml

@@ -7,7 +7,7 @@ hu:
       label_unnamed_list: 'Névtelen lista'
       label_board_type: 'Tábla típus'
       upsale:
-        teaser_text: 'Would you like to automate your workflows with Boards? Advanced boards are an Enterprise feature. Please upgrade to a paid plan.'
+        teaser_text: 'Szeretné automatizálni a munkafolyamatait a Boards-al? A fejlett táblák Enterprise funkció. Kérjük, frissítsen fizetős csomagra.'
         upgrade: 'Frissítés most'
       lists:
         delete: 'Törölt lista'

modules/boards/config/locales/crowdin/js-hu.yml

@@ -63,7 +63,7 @@ hu:
   label_example_placeholder: 'például %{decimal}'
   label_view_all_budgets: "Minden költség megtekintése"
   label_yes: "Igen"
-  notice_budget_conflict: "Work packages must be of the same project."
+  notice_budget_conflict: "A munkacsomagoknak ugyanabba a projektbe kell tartozniuk."
   notice_no_budgets_available: "Nincs költségvetés."
   permission_edit_budgets: "Költségvetés szerkesztése"
   permission_view_budgets: "Költségvetések megtekintése"

modules/budgets/config/locales/crowdin/hu.yml

@@ -80,7 +80,7 @@ et:
   label_costlog: "Logged unit costs"
   label_cost_plural: "Kulud"
   label_cost_type_plural: "Kulu liigid"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Costs per page"
   label_currency: "Currency"
   label_currency_format: "Valuuta vorming"

modules/costs/config/locales/crowdin/et.yml

@@ -80,7 +80,7 @@ fil:
   label_costlog: "Logged unit costs"
   label_cost_plural: "Costs"
   label_cost_type_plural: "Cost types"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Costs per page"
   label_currency: "Currency"
   label_currency_format: "Format of currency"

modules/costs/config/locales/crowdin/fil.yml

@@ -81,7 +81,7 @@ hr:
   label_costlog: "Zabilježeni jedinični troškovi"
   label_cost_plural: "Troškovi"
   label_cost_type_plural: "Vrsta troška"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Troškova po stranici"
   label_currency: "Valuta"
   label_currency_format: "Oblik valute"

modules/costs/config/locales/crowdin/hr.yml

@@ -81,7 +81,7 @@ lv:
   label_costlog: "Logged unit costs"
   label_cost_plural: "Costs"
   label_cost_type_plural: "Cost types"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Costs per page"
   label_currency: "Currency"
   label_currency_format: "Format of currency"

modules/costs/config/locales/crowdin/lv.yml

@@ -80,7 +80,7 @@
   label_costlog: "Logged unit costs"
   label_cost_plural: "Costs"
   label_cost_type_plural: "Cost types"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Costs per page"
   label_currency: "Currency"
   label_currency_format: "Format of currency"

modules/costs/config/locales/crowdin/no.yml

@@ -79,7 +79,7 @@ th:
   label_costlog: "Logged unit costs"
   label_cost_plural: "Costs"
   label_cost_type_plural: "Cost types"
-  label_cost_type_specific: "Cost type #%{id}: %{name}"
+  label_cost_type_specific: "Cost type #%{id}: %{name}" #%{id}: %{name}"
   label_costs_per_page: "Costs per page"
   label_currency: "Currency"
   label_currency_format: "Format of currency"

modules/costs/config/locales/crowdin/th.yml

@@ -28,7 +28,7 @@ th:
         title: "คำขอ Pull"
         copy_menu:
           label: Git snippets
-          description: คัดลอกข้อมูล git snippets ไปยังคลิปบอร์ด 
+          description: คัดลอกข้อมูล git snippets ไปยังคลิปบอร์ด
         git_actions:
           branch_name: ชื่อสาขา
           commit_message: Commit message

modules/github_integration/config/locales/crowdin/js-th.yml

@@ -32,4 +32,4 @@ th:
     pull_request_referenced_comment: >
       **Referenced in PR:** [%{github_user}](%{github_user_url}) referenced this work package in Pull request %{pr_number} [%{pr_title}](%{pr_url}) on [%{repository}](%{repository_url}).
     pull_request_ready_for_review_comment: >
-      **PR Ready for Review:** คำขอดึง %{pr_number} [%{pr_title}](%{pr_url}) สำหรับ [%{repository}](%{repository_url}) ถูกทำเครื่องหมายว่าพร้อมสำหรับการตรวจสอบโดย [%{github_user}](%{github_user_url}) 
+      **PR Ready for Review:** คำขอดึง %{pr_number} [%{pr_title}](%{pr_url}) สำหรับ [%{repository}](%{repository_url}) ถูกทำเครื่องหมายว่าพร้อมสำหรับการตรวจสอบโดย [%{github_user}](%{github_user_url})

modules/github_integration/config/locales/crowdin/th.yml

@@ -5,7 +5,7 @@ hu:
       remove: 'Widget eltávolítása'
       configure: 'Widget konfigurálása'
       upsale:
-        text: "Some widgets, like the work package graph widget, are only available in the Enterprise Edition."
+        text: "Néhány widget, például a munkacsomag-grafikon widget, csak az Enterprise Edition-ben érhető el."
         link: 'Vállalati kiadás.'
       widgets:
         custom_text:

modules/grids/config/locales/crowdin/js-hu.yml

@@ -42,8 +42,7 @@ et:
         group_name_attribute_text: 'Enter the attribute of the LDAP group used for setting the OpenProject group name.'
         filter_string_text: 'Enter the RFC4515 LDAP filter that returns groups in your LDAP to synchronize with OpenProject.'
         base_dn_text: >
-          Enter the search base DN to use for this filter. It needs to be below the base DN of the selected LDAP connection.
-          Leave this option empty to reuse the base DN of the connection
+          Enter the search base DN to use for this filter. It needs to be below the base DN of the selected LDAP connection. Leave this option empty to reuse the base DN of the connection
     synchronized_groups:
       add_new: 'Add synchronized LDAP group'
       destroy: