use csv encoding from stdlib

Author: orltom

internal/export/cv.go

@@ -1,6 +1,7 @@
 package export
 
 import (
+	"encoding/csv"
 	"fmt"
 	"io"
 	"time"
@@ -12,19 +13,25 @@ var _ apis.Exporter = &CVSExporter{}
 
 type CVSExporter struct{}
 
+func NewCVSCExporter() *CVSExporter {
+	return &CVSExporter{}
+}
+
 func (c *CVSExporter) Write(shifts []apis.Shift, writer io.Writer) error {
-	if _, err := fmt.Fprint(writer, "from,to,primary,secondary\n"); err != nil {
+	csvWriter := csv.NewWriter(writer)
+	defer csvWriter.Flush()
+
+	if err := csvWriter.Write([]string{"Start", "End", "Primary", "Secondary"}); err != nil {
 		return fmt.Errorf("write csv header: %w", err)
 	}
+
 	for i := range shifts {
 		s := shifts[i]
-		if _, err := fmt.Fprintf(writer, "\"%s\",\"%s\",\"%s\",\"%s\"\n", s.Start.Format(time.DateOnly), s.End.Format(time.DateOnly), s.Primary, s.Secondary); err != nil {
+		record := []string{s.Start.Format(time.DateOnly), s.End.Format(time.DateOnly), string(s.Primary), string(s.Secondary)}
+		if err := csvWriter.Write(record); err != nil {
 			return fmt.Errorf("write csv data: %w", err)
 		}
 	}
-	return nil
-}
 
-func NewCVSCExporter() *CVSExporter {
-	return &CVSExporter{}
+	return nil
 }

internal/export/cv_test.go

@@ -36,9 +36,9 @@ func TestCVSExporter_Write(t *testing.T) {
 					},
 				},
 			},
-			wantWriter: `from,to,primary,secondary
-"2024-12-25","2024-12-26","a","b"
-"2024-12-26","2024-12-27","c","d"
+			wantWriter: `Start,End,Primary,Secondary
+2024-12-25,2024-12-26,a,b
+2024-12-26,2024-12-27,c,d
 `,
 			wantErr: false,
 		},
@@ -47,15 +47,15 @@ func TestCVSExporter_Write(t *testing.T) {
 			args: args{
 				plan: []apis.Shift{},
 			},
-			wantWriter: "from,to,primary,secondary\n",
+			wantWriter: "Start,End,Primary,Secondary\n",
 			wantErr:    false,
 		},
 		{
 			name: "When plan is nil, print CSV header",
 			args: args{
 				plan: nil,
 			},
-			wantWriter: "from,to,primary,secondary\n",
+			wantWriter: "Start,End,Primary,Secondary\n",
 			wantErr:    false,
 		},
 	}