-
Notifications
You must be signed in to change notification settings - Fork 131
ADIOS2's HDF5 Engine to support OpenPMD #4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the interest! |
Thank you. But the definition of "most effective" is relative, I guess. :)
PS: I am happy to provide a patch if I can get help reviewing my design and patch by Adios2 contributors. |
Looks like you have particle mesh data, and wanting to use both ADIOS and HDF5 formats to store, and complying with the openPMD standard is the end goal, possibly leveraging the existing openPMD-api work will be the easier option in the long run.
Sure I can review it. |
Remember to motivate and summarize considering the community. Provide enough information to motivate such as:
Why is this feature important?
OpenPMD standard: https://github.com/openPMD/openPMD-standard/blob/latest/STANDARD.md
It will be great to have ADIOS2's HDF5 engine output is compliant with OpenPMD for wider adoption.
What is the potential impact of this feature in the community?
HDF5 outputs created by ADIOS2 with setting engine = HDF5 could be read by openPMD compliant readers.
Is your feature request related to a problem? Please describe.
HDF5 outputs created by ADIOS2 with setting engine = HDF5 cannot be read by openPMD compliant readers because it prepends the keys with "/Step0" where 0 is the step number.
Describe the solution you'd like and potential required effort
Is it possible to introduce a configuration option called "openPMD_compatible" or something similar such that when it is set to true this is calculated as:
Effort seems small.
Describe alternatives you've considered and potential required effort
Alternative is to make the prefix "/Step" to be fully customizable instead of using a setting such as openPMD_compatible setting. However, this could increase the effort.
Additional context
None
Note: contents adapted from the VTK contribution guidelines
The text was updated successfully, but these errors were encountered: