Add linter

Signed-off-by: arkadeepsen <arsen@redhat.com>

Author: arkadeepsen

Makefile

@@ -4,6 +4,18 @@ GIT_ROOT := $(shell git rev-parse --show-toplevel)
 export MCP_SERVER_PATH := $(GIT_ROOT)/_output/ovnk-mcp-server
 export KUBECONFIG := $(HOME)/ovn.conf
 
+# CONTAINER_RUNNABLE determines if the tests can be run inside a container. It checks to see if
+# podman/docker is installed on the system.
+PODMAN ?= $(shell podman -v > /dev/null 2>&1; echo $$?)
+ifeq ($(PODMAN), 0)
+CONTAINER_RUNTIME?=podman
+else
+CONTAINER_RUNTIME?=docker
+endif
+CONTAINER_RUNNABLE ?= $(shell $(CONTAINER_RUNTIME) -v > /dev/null 2>&1; echo $$?)
+
+GOPATH ?= $(shell go env GOPATH)
+
 .PHONY: build
 build:
 	go build -o $(MCP_SERVER_PATH) cmd/ovnk-mcp-server/main.go
@@ -37,3 +49,20 @@ run-e2e:
 
 .PHONY: test-e2e
 test-e2e: build deploy-kind-ovnk run-e2e undeploy-kind-ovnk
+
+.PHONY: lint
+lint:
+ifeq ($(CONTAINER_RUNNABLE), 0)
+	@GOPATH=${GOPATH} ./hack/lint.sh $(CONTAINER_RUNTIME) || { echo "lint failed! Try running 'make lint-fix'"; exit 1; }
+else
+	echo "linter can only be run within a container since it needs a specific golangci-lint version"; exit 1
+endif
+
+.PHONY: lint-fix
+lint-fix:
+ifeq ($(CONTAINER_RUNNABLE), 0)
+	@GOPATH=${GOPATH} ./hack/lint.sh ${CONTAINER_RUNTIME} fix || { echo "ERROR: lint fix failed! There is a bug that changes file ownership to root \
+	when this happens. To fix it, simply run 'chown -R <user>:<group> *' from the repo root."; exit 1; }
+else
+	echo "linter can only be run within a container since it needs a specific golangci-lint version"; exit 1
+endif

hack/lint.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+VERSION=v1.64.8
+extra_flags=""
+if [ "$#" -ne 1 ]; then
+  if [ "$#" -eq 2 ] && [ "$2" == "fix" ]; then
+    extra_flags="--fix"
+  else
+    echo "Expected command line argument - container runtime (docker/podman) got $# arguments: $*"
+    exit 1
+  fi
+fi
+
+$1 run --security-opt label=disable --rm \
+  -v  "${HOME}"/.cache/golangci-lint:/cache -e GOLANGCI_LINT_CACHE=/cache \
+  -v "$(pwd)":/app -w /app -e GO111MODULE=on docker.io/golangci/golangci-lint:"${VERSION}" \
+	golangci-lint run --verbose --print-resources-usage \
+	--modules-download-mode=vendor --timeout=15m0s ${extra_flags} && \
+	echo "lint OK!"