Add golangci-lint infra for code quality checks #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluhrsen
force-pushed
the
add-golangci-lint
branch
from
c3f6d05 to
25fb424
Compare
This adds linting support using golangci-lint v1.64.8 via containerized execution, matching the approach used in ovn-kubernetes. Includes a Makefile with lint and lint-fix targets, a GitHub Actions workflow for automated PR checks, and the necessary hack/lint.sh script. This work was patterned mostly from what is in ovn-kubernetes/ovn-kubernetes.git except that the github actions will now use 'make lint' instead of a github marketplace action so that the lint in CI will match exactly what a dev would do locally Assisted-by: Claude Code Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
jluhrsen
force-pushed
the
add-golangci-lint
branch
from
25fb424 to
f8c29ab
Compare
Author
|
If anyone is looking at this, I created this as part of a learning session with "Claude Code" I think it's close to what we would want and may make sense to let in. The lint job fails with the repo at this state because there is no golang. here is a job on my fork showing what that looks like, but I think if current dev work rebased on top of this we would then have linting working for everyone. or we can throw this away and do it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lintandlint-fixtargetshack/lint.shscript for containerized linting using golangci-lint v1.64.8make linton PRs and pushes to mainTest plan
Assisted-by: Claude Code