[#IOPID-2514] upgrade to node20 (#166)

Author: arcogabbo

.devops/code-review-pipelines.yml

@@ -2,7 +2,7 @@
 # 
 
 variables:
-  NODE_VERSION: '18.13.0'
+  NODE_VERSION: '20.12.2'
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
   setupTemplateName: azure-templates/setup-project.yml
 

.devops/deploy-pipelines.yml

@@ -9,7 +9,7 @@
 # 
 
 variables:
-  NODE_VERSION: '18.13.0'
+  NODE_VERSION: '20.12.2'
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
   gitReference: ${{ replace(replace(variables['Build.SourceBranch'], 'refs/tags/', ''), 'refs/heads/', '') }}
 

.eslintrc.js

@@ -21,6 +21,9 @@ module.exports = {
         "@pagopa/eslint-config/strong",
     ],
     "rules": {
-        
+        "jsdoc/newline-after-description": "off",
+        // this rule is a replacement for the above one which got removed but it's still
+        // mentioned in @pagopa/eslint-config@3.0.0
+        "jsdoc/tag-lines": ["error", "any", {"startLines": 1}]
     }
 }

.node-version

@@ -1 +1 @@
-18.13.0
+20.12.2

.nvmrc

@@ -1,4 +1,4 @@
-FROM node:18.13.0 as builder
+FROM node:20.12.2 AS builder
 
 WORKDIR /usr/src/app
 
@@ -11,7 +11,7 @@ RUN chmod -R 777 /usr/src/app \
   && yarn install \
   && yarn build
 
-FROM node:18.13.0-alpine
+FROM node:20.12.2-alpine
 LABEL maintainer="https://pagopa.gov.it"
 
 WORKDIR /usr/src/app
@@ -23,4 +23,6 @@ COPY --from=builder /usr/src/app/node_modules /usr/src/app/node_modules
 
 EXPOSE 3000
 
+USER node
+
 CMD ["yarn", "dev"]

Dockerfile

@@ -2,7 +2,7 @@ version: "2.2"
 
 services:
   io-spid-commons:
-    image: node:18.13.0-alpine
+    image: node:20.12.2-alpine
     working_dir: /usr/src/app
     volumes:
       - ".:/usr/src/app"

docker-compose.override.dev.yml

@@ -13,7 +13,7 @@ services:
       - "3000"
     ports:
       - "3000:3000"
-    image: node:18.13.0-alpine
+    image: node:20.12.2-alpine
     working_dir: /usr/src/app
     volumes:
       - "./certs:/usr/src/app/certs:delegated"

docker-compose.yml

@@ -28,7 +28,7 @@
     "@pagopa/eslint-config": "^3.0.0",
     "@types/express": "4.17.11",
     "@types/jest": "^29.5.1",
-    "@types/node": "~18.13.0",
+    "@types/node": "~20.12.2",
     "@types/node-fetch": "^2.1.2",
     "@types/node-forge": "^0.9.1",
     "@types/passport": "^1.0.2",
@@ -39,11 +39,11 @@
     "@types/xml-crypto": "^1.4.1",
     "@types/xml2js": "^0.4.5",
     "@types/yargs": "^15.0.4",
-    "fp-ts": "^2.16.5",
-    "io-ts": "^2.2.21",
     "auto-changelog": "^2.2.1",
     "eslint-plugin-prettier": "^4.2.1",
     "express": "4.17.0",
+    "fp-ts": "^2.16.5",
+    "io-ts": "^2.2.21",
     "jest": "^29.5.0",
     "nock": "^11.7.1",
     "nodemon": "^2.0.2",
@@ -100,6 +100,7 @@
     "access": "public"
   },
   "resolutions": {
-    "@types/express-serve-static-core": "4.17.34"
+    "@types/express-serve-static-core": "4.17.34",
+    "eslint-plugin-jsdoc": "^50"
   }
 }