BUG: fix fill value for gouped sum in case of unobserved categories for string dtype (empty string instead of 0) #61909
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or string dtype (empty string instead of 0)
jorisvandenbossche
added
Bug
Groupby
Strings
| @@ -729,6 +730,10 @@ def group_sum( | |||
| sumx = np.zeros((<object>out).shape, dtype=(<object>out).base.dtype) | |||
| compensation = np.zeros((<object>out).shape, dtype=(<object>out).base.dtype) | |||
|
|
|||
| if is_string: | |||
| # for strings start with empty string instead of 0 as `initial` value | |||
| sumx = np.full((<object>out).shape, "", dtype=object) | |||
There was a problem hiding this comment.
Would passing “initial” be more general/idiomatic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into one more case of the sum of empty / all-NaN to use "0" instead of empty string (#60229), specifically when effectively introducing empty groups with categorical data with observed=False.
Follow-up on #60936
The passing through of
is_stringthrough several layers is a bit annoying, but effectively is needed to for now only changes this for string dtype, and not for object dtype in general (which in the other PR related to this, we did for now)