Bug: failing tests off main with golang 1.25

[stan-dot]

pants test ::
12:14:21.79 [INFO] Completed: Scheduling: Parse go.mod
12:14:21.80 [ERROR] 1 Exception encountered:

Engine traceback:
in test goal

ProcessExecutionFailure: Process 'Parse go.mod' failed with exit code 2.
stdout:

stderr:
go: unknown GOEXPERIMENT coverageredesign

Use --keep-sandboxes=on_failure to preserve the process chroot for inspection.

version:

 cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 13 (trixie)"
NAME="Debian GNU/Linux"
VERSION_ID="13"
VERSION="13 (trixie)"
VERSION_CODENAME=trixie
DEBIAN_VERSION_FULL=13.1
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

this is running on a devcontainer based on docker.io/golang:1.25.1-trixie

[benjyw]

Looks like that experiment was removed in Go 1.25, and the new "coverage redesign" is always on.

@tdyas , according to this code we disable that experiment because we don't support the new coverage redesign yet. But that disabling is no longer possible (and causing the error posted above). So now we will have to support it in 1.25 and higher. Do you recall what that would involve?

[tdyas]

Related Pants issues and PRs:

• go: disable coverage redesign experiment on Go v1.20+ pants#18205
• Add support for coverage with Go v1.21+  pants#20689
• Go v1.20 supports coverage analysis of non-test (i.e., ordinary) binaries pants#17951

[tdyas]

The conditional checking the Go version may be inverted.

[tdyas]

pantsbuild/pants#22809 is the fix.

[benjyw]

@stan-dot is this workaround acceptable in your case? Basically it means not being able to use coverage on go 1.25 until pantsbuild/pants#17951 is implemented.

[stan-dot]

checking now

[stan-dot]

1.25 was not essential for my use case, just tried with image: FROM docker.io/golang:1.24.9-trixie and it all worked

[stan-dot]

I made a small PR updating some deps. can remove the devcontainer part if you consider it out of scope - #27