Skip to content
This repository was archived by the owner on Jul 29, 2022. It is now read-only.
This repository was archived by the owner on Jul 29, 2022. It is now read-only.

Put back CI=true when running on CI #915

@amaury1093

Description

@amaury1093

In #896, I added CI=false in the yarn build:extension step: https://github.com/paritytech/substrate-light-ui/pull/896/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R22

This is to avoid a known webpack issue around dynamic requires, introduced by using wasm, see for example drager/wasm-pack#822:

Critical dependency: the request of a dependency is an expression

It's really not critical, and everything works with this CI=false. Just a reminder issue.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions