fix: retrieve via cache key

patrickmichalina · patrickmichalina · commit cda82b578981 · 2018-07-12T15:47:22.000-05:00
diff --git a/src/modules/firebase/server.firebase.rtdb.service.ts b/src/modules/firebase/server.firebase.rtdb.service.ts
@@ -44,7 +44,7 @@ function attemptToCacheInLru(key: string, lru?: LruCache) {
 }
 
 function attemptToGetCachedValue<T>(key: string, lru?: LruCache) {
-  return lru && lru.get<T>(key)
+  return lru && lru.get<T>(sha256(key))
 }
 
 // tslint:disable:no-this
@@ -66,7 +66,7 @@ export class ServerUniversalRtDbService implements IUniversalRtdbService {
     const url = constructFbUrl(this.afdb, path)
     const params = getParams({ auth: this.authToken })
     const cacheKey = getFullUrl(url, params)
-    const cachedValue = attemptToGetCachedValue<T>(cacheKey)
+    const cachedValue = attemptToGetCachedValue<T>(cacheKey, this.lru)
 
     const baseObs = this.authToken
       ? this.http.get<T>(url, { params })

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function attemptToCacheInLru(key: string, lru?: LruCache) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`function attemptToGetCachedValue<T>(key: string, lru?: LruCache) {`
`47`		`- return lru && lru.get<T>(key)`
	`47`	`+ return lru && lru.get<T>(sha256(key))`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`// tslint:disable:no-this`
`@@ -66,7 +66,7 @@ export class ServerUniversalRtDbService implements IUniversalRtdbService {`
`66`	`66`	`const url = constructFbUrl(this.afdb, path)`
`67`	`67`	`const params = getParams({ auth: this.authToken })`
`68`	`68`	`const cacheKey = getFullUrl(url, params)`
`69`		`- const cachedValue = attemptToGetCachedValue<T>(cacheKey)`
	`69`	`+ const cachedValue = attemptToGetCachedValue<T>(cacheKey, this.lru)`
`70`	`70`
`71`	`71`	`const baseObs = this.authToken`
`72`	`72`	`? this.http.get<T>(url, { params })`