Skip to content

Commit bda538f

Browse files
authored
Backtracking on styled-components (#319)
* revert: backtrack on styled-components, too chonk * chore: prettier
1 parent 5f20088 commit bda538f

File tree

9 files changed

+36
-155
lines changed

9 files changed

+36
-155
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
"main": "dist/main.js",
2323
"peerDependencies": {
2424
"react": ">15.4.2 <17.0.0",
25-
"react-dom": ">15.4.2 <17.0.0",
26-
"styled-components": "^4.0.0"
25+
"react-dom": ">15.4.2 <17.0.0"
2726
},
2827
"dependencies": {
2928
"classnames": "^2.2.5",
@@ -92,7 +91,6 @@
9291
"sass-loader": "^7.1.0",
9392
"sinon": "^1.17.4",
9493
"storybook-addon-react-docgen": "^1.0.4",
95-
"styled-components": "^4.0.0",
9694
"style-loader": "^0.23.1",
9795
"uglifyjs-webpack-plugin": "^2.0.1",
9896
"url-loader": "^1.1.2",

src/components/CountryList.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
21
import React, { Component } from 'react';
32
import PropTypes from 'prop-types';
43
import classNames from 'classnames';
54
import utils from './utils';
65

76
import FlagBox from './FlagBox';
8-
import { Divider } from './CountryList.styles'
97

108
export default class CountryList extends Component {
119
static propTypes = {
@@ -32,7 +30,7 @@ export default class CountryList extends Component {
3230
}
3331

3432
setDropdownPosition = () => {
35-
this.listElement.classList.remove('hide')
33+
this.listElement.classList.remove('hide');
3634
const inputTop = this.props.inputTop;
3735
const windowTop =
3836
window.pageYOffset !== undefined
@@ -60,7 +58,7 @@ export default class CountryList extends Component {
6058
: '';
6159

6260
this.listElement.style.top = cssTop;
63-
this.listElement.classList.remove('v-hide')
61+
this.listElement.classList.remove('v-hide');
6462
};
6563

6664
appendListItem = (countries, isPreferred = false) => {
@@ -116,6 +114,7 @@ export default class CountryList extends Component {
116114

117115
const preferredOptions = this.appendListItem(preferredCountries, true);
118116
const allOptions = this.appendListItem(countries);
117+
const divider = <div className="divider" />;
119118

120119
return (
121120
<ul
@@ -125,7 +124,7 @@ export default class CountryList extends Component {
125124
className={className}
126125
>
127126
{preferredOptions}
128-
{preferredCountries.length > 0 ? <Divider /> : null}
127+
{preferredCountries.length > 0 ? divider : null}
129128
{allOptions}
130129
</ul>
131130
);

src/components/CountryList.styles.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/components/FlagDropDown.js

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ import classNames from 'classnames';
44
import CountryList from './CountryList';
55
import RootModal from './RootModal';
66

7-
import {
8-
DownArrow,
9-
UpArrow,
10-
SelectedFlagPopoverButton,
11-
} from './FlagDropDown.styles';
12-
137
export default class FlagDropDown extends Component {
148
static propTypes = {
159
allowDropdown: PropTypes.bool,
@@ -42,9 +36,9 @@ export default class FlagDropDown extends Component {
4236

4337
genArrow = () => {
4438
const { allowDropdown, showDropdown } = this.props;
45-
const arrow = showDropdown ? <UpArrow /> : <DownArrow />;
39+
const arrowClasses = classNames('arrow', showDropdown ? 'up' : 'down');
4640

47-
return allowDropdown ? arrow : null;
41+
return allowDropdown ? <div className={arrowClasses} /> : null;
4842
};
4943

5044
genFlagClassName = () =>
@@ -99,7 +93,7 @@ export default class FlagDropDown extends Component {
9993

10094
return (
10195
<div ref={refCallback} className="flag-container">
102-
<SelectedFlagPopoverButton
96+
<div
10397
className="selected-flag"
10498
tabIndex={allowDropdown ? '0' : ''}
10599
onClick={clickSelectedFlag}
@@ -109,7 +103,7 @@ export default class FlagDropDown extends Component {
109103
<div className={this.genFlagClassName()} />
110104
{this.genSelectedDialCode()}
111105
{this.genArrow()}
112-
</SelectedFlagPopoverButton>
106+
</div>
113107
{dropdownContainer && showDropdown ? (
114108
<RootModal>{this.genCountryList()}</RootModal>
115109
) : (

src/components/FlagDropDown.styles.js

Lines changed: 0 additions & 24 deletions
This file was deleted.

src/components/IntlTelInput.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import AllCountries from './AllCountries';
77
import FlagDropDown from './FlagDropDown';
88
import TelInput from './TelInput';
99
import utils from './utils';
10-
import { KEYS } from './constants'
10+
import { KEYS } from './constants';
1111
import '../styles/intlTelInput.scss';
1212

1313
const mobileUserAgentRegexp = /Android.+Mobile|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i;
@@ -1017,7 +1017,7 @@ class IntlTelInput extends Component {
10171017
this.wrapperClass['separate-dial-code'] = this.props.separateDialCode;
10181018

10191019
if (this.isMobile && this.props.useMobileFullscreenDropdown) {
1020-
document.querySelector('body').classList.add('iti-mobile')
1020+
document.querySelector('body').classList.add('iti-mobile');
10211021
// on mobile, we want a full screen dropdown, so we must append it to the body
10221022
this.dropdownContainer = 'body';
10231023
window.addEventListener('scroll', this.handleWindowScroll);

src/components/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export default {
170170

171171
return {};
172172
},
173-
173+
174174
findIndex(items, predicate) {
175175
let index = -1;
176176

src/styles/intlTelInput.scss

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,20 @@ $mobilePopupMargin: 30px;
7575
right: 0;
7676
// prevent the highlighted child from overlapping the input border
7777
padding: $borderWidth;
78+
79+
.arrow {
80+
font-size: 6px;
81+
margin-left: 5px;
82+
83+
&.up:after {
84+
content: '';
85+
}
86+
87+
&.down:after {
88+
content: '';
89+
90+
}
91+
}
7892
}
7993

8094
.selected-flag {
@@ -85,6 +99,10 @@ $mobilePopupMargin: 30px;
8599
// this must be full-height both for the hover highlight, and to push down the
86100
// dropdown so it appears below the input
87101
height: 100%;
102+
103+
display: flex;
104+
justify-content: center;
105+
align-items: center;
88106
}
89107

90108
// the dropdown
@@ -97,6 +115,12 @@ $mobilePopupMargin: 30px;
97115
list-style: none;
98116
// in case any container has text-align:center
99117
text-align: left;
118+
119+
.divider {
120+
padding-bottom: 5px;
121+
margin-bottom: 5px;
122+
border-bottom: $borderWidth solid $greyBorder;
123+
}
100124

101125
// place menu above the input element
102126
&.dropup {

0 commit comments

Comments
 (0)