Merge pull request #6 from pdffiller/travis

travis

Author: osadchyi-s

.travis.yml

@@ -0,0 +1,90 @@
+sudo: false
+
+language: php
+php:
+  - '7.3'
+  - '7.2'
+  - '7.1'
+
+matrix:
+  fast_finish: true
+  allow_failures:
+    - php: 'master'
+
+services:
+  - redis-server
+
+git:
+  depth: 1
+
+branches:
+  only:
+    - master
+    - development
+
+cache:
+  apt: true
+  ccache: true
+  timeout: 604800
+  directories:
+    - $HOME/.composer/cache
+    - $HOME/bin
+
+env:
+  global:
+    - REDIS_HOST="127.0.0.1"
+    - REDIS_PORT="6379"
+    - REDIS_TIMEOUT="0.0"
+    - DEFAULT_COMPOSER_FLAGS="--no-interaction --no-ansi --no-progress --no-suggest"
+
+before_install:
+  - if [[ ! -z "${GH_TOKEN}" ]]; then composer config github-oauth.github.com ${GH_TOKEN}; echo "Configured Github token"; fi;
+  - ulimit -c unlimited -S || true
+
+install:
+  - composer install $DEFAULT_COMPOSER_FLAGS
+  - |
+      if [ ! -f $HOME/bin/infection ]; then
+        wget https://github.com/infection/infection/releases/download/0.10.3/infection.phar
+        wget https://github.com/infection/infection/releases/download/0.10.3/infection.phar.asc
+        chmod +x infection.phar
+        gpg --keyserver hkps.pool.sks-keyservers.net --recv-keys 493B4AA0
+        gpg --with-fingerprint --verify infection.phar.asc infection.phar
+        mkdir -p $HOME/bin && mv infection.phar $HOME/bin/infection
+      fi
+
+before_script:
+  - composer diagnose || true
+
+script:
+  - ./vendor/bin/phpunit --disallow-test-output
+
+after_success:
+  - if [[ ! -z "${CODECOV_TOKEN}" ]]; then (bash <(curl -s https://codecov.io/bash) || echo "Codecov did not collect coverage reports"); fi;
+
+after_failure:
+  - $(phpenv which php) -v
+  - for m in `$(phpenv which php) -m | grep -e 'json\|pcntl\|posix\|sockets\|pcre'`; do php --ri $m; done
+
+notifications:
+  email: false
+
+jobs:
+  include:
+    - stage: Static Code Analysis
+      php: 7.2
+      env: PHPStan
+      script:
+        - ./vendor/bin/phpstan analyse src/ --level max
+    - stage: Static Code Analysis
+      php: 7.2
+      env: PHP_CodeSniffer
+      before_script:
+        - phpenv config-rm xdebug.ini || true
+      script:
+        - ./vendor/bin/phpcs src
+    - stage: Mutation Testing
+      php: 7.2
+      script:
+        - ./vendor/bin/phpunit --disallow-test-output
+        - $HOME/bin/infection --threads=4

composer.json

@@ -20,8 +20,11 @@
     },
     "require-dev": {
         "illuminate/events": "5.6.*|5.7.*",
+        "infection/infection": "^0.12.0",
         "orchestra/testbench": "~3.0",
-        "phpunit/phpunit": ">=5.3 <8.0"
+        "phpstan/phpstan": "^0.11.1",
+        "phpunit/phpunit": ">=5.3 <8.0",
+        "squizlabs/php_codesniffer": "^3.4"
     },
     "autoload": {
         "psr-4": {

infection.json.dist

@@ -0,0 +1,15 @@
+{
+  "source": {
+    "directories": [
+      "src"
+    ]
+  },
+  "timeout": 15,
+  "logs": {
+    "text": "infection-log.txt",
+    "json": "infection-log.json",
+    "badge": {
+      "branch": "master"
+    }
+  }
+}

phpcs.xml.dist

@@ -0,0 +1,39 @@
+<?xml version="1.0"?>
+<ruleset name="LaravelQless">
+
+    <!--
+        The name attribute of the ruleset tag is displayed
+        when running PHP_CodeSniffer with the -v command line
+        argument. The description tag below is not displayed anywhere
+        except in this file, so it can contain information for
+        developers who may change this file in the future.
+    -->
+    <description>The coding standard for LaravelQless</description>
+
+    <!-- Show sniff codes in all reports -->
+    <arg value="s"/>
+
+    <!-- Use PSR-2 as a base -->
+    <rule ref="PSR2"/>
+
+    <!-- Uncomment to use colors in progress or report -->
+    <!-- arg name="colors" / -->
+
+    <!--
+        If no files or directories are specified on the command line
+        your custom standard can specify what files should be checked
+        instead.
+        Note that specifying any file or directory path
+        on the command line will ignore all file tags.
+    -->
+    <file>src</file>
+    <file>tests</file>
+
+    <!--
+        You can hard-code ignore patterns directly into your
+        custom standard so you don't have to specify the
+        patterns on the command line.
+    -->
+    <exclude-pattern>tests/bootstrap.php</exclude-pattern>
+    <exclude-pattern>tests/publish.php</exclude-pattern>
+</ruleset>

phpstan.neon

@@ -0,0 +1,5 @@
+parameters:
+  reportUnmatchedIgnoredErrors: false
+  ignoreErrors:
+      - '#Cannot access offset#'
+      - '#Method LaravelQless\\Queue\\QlessQueue::makePayload\(\) should return string but returns string|false.#'

src/Handler/DefaultHandler.php

@@ -5,8 +5,15 @@
 use LaravelQless\Contracts\JobHandler;
 use Qless\Jobs\BaseJob;
 
+/**
+ * Class DefaultHandler
+ * @package LaravelQless\Handler
+ */
 class DefaultHandler implements JobHandler
 {
+    /**
+     * @param BaseJob $job
+     */
     public function perform(BaseJob $job): void
     {
         $job->perform();

src/Job/QlessJob.php

@@ -148,17 +148,17 @@ public function maxTries()
     /**
      * Get the number of seconds the job can run.
      *
-     * @return int|null
+     * @return int
      */
     public function timeout()
     {
-        return $this->job->ttl();
+        return (int) $this->job->ttl();
     }
 
     /**
      * Get the timestamp indicating when the job should timeout.
      *
-     * @return int|null
+     * @return int
      */
     public function timeoutAt()
     {

src/Queue/QlessQueue.php

@@ -6,8 +6,10 @@
 use Illuminate\Queue\InvalidPayloadException;
 use Illuminate\Queue\Queue;
 use LaravelQless\Contracts\JobHandler;
+use LaravelQless\Job\AbstractJob;
 use LaravelQless\Job\QlessJob;
 use Qless\Client;
+use Qless\Jobs\BaseJob;
 use Qless\Topics\Topic;
 
 /**
@@ -56,7 +58,7 @@ public function __construct(Client $connect, array $config)
      */
     public function size($queue = null): int
     {
-        return $this->getConnection()->length($queue);
+        return $this->getConnection()->length($queue ?? '');
     }
 
     /**
@@ -159,13 +161,14 @@ public function recur(int $interval, string $job, array $data, ?string $queueNam
      * Pop the next job off of the queue.
      *
      * @param  string  $queueName
-     * @return \Illuminate\Contracts\Queue\Job|null|QlessJob
+     * @return QlessJob|null
      */
     public function pop($queueName = null)
     {
         /** @var \Qless\Queues\Queue $queue */
         $queue = $this->getConnection()->queues[$queueName];
 
+        /** @var BaseJob $job */
         $job = $queue->pop(self::WORKER_PREFIX . $this->connect->getWorkerName());
 
         if (!$job) {
@@ -220,7 +223,7 @@ public function unSubscribe(string $topic, string $queueName = null): bool
      * @param array $options
      * @return array|string
      */
-    public function pushToTopic(string $topicName, string $job, array $data = [], array $options = []): array
+    public function pushToTopic(string $topicName, string $job, array $data = [], array $options = [])
     {
         $topic = new Topic($topicName, $this->getConnection());
 
@@ -247,10 +250,15 @@ public function pushToTopic(string $topicName, string $job, array $data = [], ar
      */
     protected function makePayload($job, $data = [], $options = []): string
     {
-        if (is_object($job)) {
+        $displayName = '';
+        if ($job instanceof AbstractJob) {
             $displayName = get_class($job);
             $data = array_merge($job->toArray(), $data);
-        } else {
+        } elseif (is_object($job)) {
+            $displayName = get_class($job);
+        }
+
+        if (is_string($job)) {
             $displayName = explode('@', $job)[0];
         }