Build matrix for pdfpc features (#676)

Build matrix for pdfpc features. Drop unneeded sources if markdown/mdview unselected 

---------

Co-authored-by: Evgeny <evgeny@si-o-net.com>

Author: AndreasBilke

.github/workflows/cmake-ubuntu.yml

@@ -17,18 +17,49 @@ jobs:
     # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
     runs-on: ubuntu-latest
 
+    strategy:
+        matrix:
+            build_movies: [movies_on, movies_off]
+            build_mdview: [mdview_on, mdview_off]
+            build_rest: [rest_on, rest_off]
+
+            include:
+                - movies_packages:
+                - movies_build_flag: off
+
+                - movies_packages: libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
+                  build_movies: movies_on
+                - movies_build_flag: on
+                  build_movies: movies_on
+
+                - mdview_packages:
+                - mdview_build_flag: off
+
+                - mdview_packages: libwebkit2gtk-4.0-dev libmarkdown2-dev
+                  build_mdview: mdview_on
+                - mdview_build_flag: on
+                  build_mdview: mdview_on
+
+                - rest_packages:
+                - rest_build_flag: off
+
+                - rest_packages: libsoup2.4-dev libqrencode-dev libmarkdown2-dev
+                  build_rest: rest_on
+                - rest_build_flag: on
+                  build_rest: rest_on
+
     steps:
     - uses: actions/checkout@v3
 
     - name: requirements
       run: |
         sudo apt update
-        sudo apt -y install cmake valac libunwind-dev libgee-0.8-dev libpoppler-glib-dev libgtk-3-dev libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev libjson-glib-dev libmarkdown2-dev libwebkit2gtk-4.0-dev libsoup2.4-dev libqrencode-dev
+        sudo apt -y install cmake valac libunwind-dev libgee-0.8-dev libpoppler-glib-dev libgtk-3-dev libjson-glib-dev ${{ matrix.movies_packages }} ${{ matrix.mdview_packages }} ${{ matrix.rest_packages }}
 
     - name: Configure CMake
       # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
       # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DMOVIES=${{ matrix.movies_build_flag }} -DMDVIEW=${{ matrix.mdview_build_flag }} -DREST=${{ matrix.rest_build_flag }}
 
     - name: Build
       # Build your program with the given configuration

src/CMakeLists.txt

@@ -4,7 +4,6 @@ pkg_check_modules(GIO REQUIRED gio-2.0)
 pkg_check_modules(GEE REQUIRED gee-0.8)
 pkg_check_modules(POPPLER REQUIRED poppler-glib>=0.80)
 pkg_check_modules(GTK REQUIRED gtk+-3.0>=3.22)
-pkg_check_modules(MARKDOWN REQUIRED libmarkdown)
 pkg_check_modules(JSON REQUIRED json-glib-1.0)
 list (FIND GTK_STATIC_LIBRARIES "X11" _index)
 if (${_index} GREATER -1)
@@ -29,10 +28,13 @@ if (MOVIES)
     )
 endif ()
 
+if (MDVIEW OR REST)
+    pkg_check_modules(MARKDOWN REQUIRED libmarkdown)
+endif ()
+
 if (MDVIEW)
     pkg_check_modules(WEBKIT REQUIRED webkit2gtk-4.0)
     set(MDVIEW_PACKAGES webkit2gtk-4.0)
-    set(EXTRA_VALA_OPTIONS ${EXTRA_VALA_OPTIONS} -D MDVIEW)
 endif ()
 
 if (REST)
@@ -112,6 +114,14 @@ else ()
     LIST(REMOVE_ITEM VALA_SRC classes/rest_server.vala)
     LIST(REMOVE_ITEM VALA_SRC classes/window/qrcode.vala)
 endif ()
+if (MDVIEW)
+    set(EXTRA_VALA_OPTIONS ${EXTRA_VALA_OPTIONS} -D MDVIEW)
+else ()
+    LIST(REMOVE_ITEM VALA_SRC classes/view/markdown.vala)
+endif ()
+if (NOT MARKDOWN_FOUND)
+    LIST(REMOVE_ITEM VALA_SRC classes/renderer/markdown.vala)
+endif ()
 
 # Check for some compiler flags to suppress excessive Vala-triggered warnings
 # Since gcc >= 4.4 can silently ignore unrecognized -W-no* flags, we test

src/classes/view/markdown.vala

@@ -21,7 +21,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#if MDVIEW
 namespace pdfpc.View {
     public class MarkdownView : WebKit.WebView {
         WebKit.UserContentManager ucm;
@@ -76,4 +75,3 @@ namespace pdfpc.View {
         }
     }
 }
-#endif