Skip to content

Commit 917c4c4

Browse files
committed
(r) Remove redundant signing determination code from build system
1 parent bde73ba commit 917c4c4

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ jobs:
289289
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
290290
WIN_CERT_PASSWORD: ${{ secrets[matrix.config.certificate-password-secret] }}
291291
WIN_CERT_CONTAINER_NAME: ${{ secrets[matrix.config.certificate-container] }}
292-
WIN_SIGNING_ENABLED: ${{ secrets[matrix.config.certificate-password-secret] != '' }}
293292

294293
strategy:
295294
matrix:

electron-app/scripts/windowsCustomSign.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
const childProcess = require('child_process');
22

33
exports.default = async function (configuration) {
4-
if (
5-
!process.env.GITHUB_ACTIONS ||
6-
process.env.WIN_SIGNING_ENABLED !== 'true'
7-
) {
4+
if (!process.env.GITHUB_ACTIONS || process.env.CAN_SIGN !== 'true') {
85
return;
96
}
107

0 commit comments

Comments
 (0)