Fix: Recreate disconnected connections when being retrieved (#19)

Namoshek · web-flow · commit 7dfaac06e49a · 2022-01-08T14:23:13.000+01:00
diff --git a/src/ConnectionManager.php b/src/ConnectionManager.php
@@ -60,6 +60,12 @@ public function connection(string $name = null): MqttClientContract
             $name = $this->defaultConnection;
         }
 
+        // Remove the connection if it is in a disconnected state.
+        // Doing this instead of simply reconnecting ensures the caller will get a fresh connection.
+        if (array_key_exists($name, $this->connections) && !$this->connections[$name]->isConnected()) {
+            unset($this->connections[$name]);
+        }
+
         if (!array_key_exists($name, $this->connections)) {
             $this->connections[$name] = $this->createConnection($name);
         }

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,12 @@ public function connection(string $name = null): MqttClientContract`
`60`	`60`	`$name = $this->defaultConnection;`
`61`	`61`	`}`
`62`	`62`
	`63`	`+ // Remove the connection if it is in a disconnected state.`
	`64`	`+ // Doing this instead of simply reconnecting ensures the caller will get a fresh connection.`
	`65`	`+ if (array_key_exists($name, $this->connections) && !$this->connections[$name]->isConnected()) {`
	`66`	`+ unset($this->connections[$name]);`
	`67`	`+ }`
	`68`	`+`
`63`	`69`	`if (!array_key_exists($name, $this->connections)) {`
`64`	`70`	`$this->connections[$name] = $this->createConnection($name);`
`65`	`71`	`}`