@@ -58,7 +58,6 @@ bool php_v8_object_store_self_ptr(php_v8_value_t *php_v8_value, v8::Local<v8::Ob
58
58
{
59
59
assert (NULL != v8::Isolate::GetCurrent ());
60
60
assert (v8::Isolate::GetCurrent ()->InContext ());
61
- assert (v8::Isolate::GetCurrent ()->GetCurrentContext () == local_object->CreationContext ());
62
61
63
62
v8::Local<v8::Private> key = php_v8_isolate_get_key_local (php_v8_value->php_v8_isolate );
64
63
assert (!key.IsEmpty ());
@@ -79,13 +78,8 @@ bool php_v8_object_store_self_ptr(php_v8_value_t *php_v8_value, v8::Local<v8::Ob
79
78
80
79
php_v8_value_t * php_v8_object_get_self_ptr (php_v8_isolate_t *php_v8_isolate, v8::Local<v8::Object> local_object)
81
80
{
82
- // assert(isolate->InContext())
83
81
assert (NULL != v8::Isolate::GetCurrent ());
84
82
assert (v8::Isolate::GetCurrent ()->InContext ());
85
- assert (v8::Isolate::GetCurrent ()->GetCurrentContext () == local_object->CreationContext ());
86
-
87
- // PHP_V8_ISOLATE_ENTER(isolate);
88
- // PHP_V8_CONTEXT_ENTER(local_object->CreationContext());
89
83
90
84
v8::Local<v8::Private> key = php_v8_isolate_get_key_local (php_v8_isolate);
91
85
assert (!key.IsEmpty ());
@@ -98,7 +92,8 @@ php_v8_value_t * php_v8_object_get_self_ptr(php_v8_isolate_t *php_v8_isolate, v8
98
92
99
93
v8::Local<v8::Value> local_value = maybe_local_value.ToLocalChecked ();
100
94
101
- // assert(local_value->IsExternal()); // TODO: for some reason this check fails, but value IS external
95
+ // for some reason this check fails, but value IS external
96
+ // assert(local_value->IsExternal());
102
97
103
98
return static_cast <php_v8_value_t *>(local_value.As <v8::External>()->Value ());
104
99
}
0 commit comments