Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit a7b54c0

Browse files
committed
Do not init ICU as we suppose to use system ICU
1 parent fdced1d commit a7b54c0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/php_v8_a.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ void php_v8_init()
2929
return;
3030
}
3131

32-
v8::V8::InitializeICU(); // TODO: check whether we actually initialized it
3332
// NOTE: if we use snapshot and extenal startup data then we have to initialize it (see https://codereview.chromium.org/315033002/)
3433
// v8::V8::InitializeExternalStartupData(NULL);
3534
v8::Platform *platform = v8::platform::CreateDefaultPlatform();

0 commit comments

Comments
 (0)