Update lint rules, force testify/assert for tests

Use testify's assert package instead of the standard library's testing
package.

Author: Sean-Der

.golangci.yml

@@ -19,12 +19,16 @@ linters-settings:
             recommendations:
               - errors
   forbidigo:
+    analyze-types: true
     forbid:
       - ^fmt.Print(f|ln)?$
       - ^log.(Panic|Fatal|Print)(f|ln)?$
       - ^os.Exit$
       - ^panic$
       - ^print(ln)?$
+      - p: ^testing.T.(Error|Errorf|Fatal|Fatalf|Fail|FailNow)$
+        pkg: ^testing$
+        msg: "use testify/assert instead"
   varnamelen:
     max-distance: 12
     min-name-length: 2
@@ -127,9 +131,12 @@ issues:
   exclude-dirs-use-default: false
   exclude-rules:
     # Allow complex tests and examples, better to be self contained
-    - path: (examples|main\.go|_test\.go)
+    - path: (examples|main\.go)
       linters:
+        - gocognit
         - forbidigo
+    - path: _test\.go
+      linters:
         - gocognit
 
     # Allow forbidden identifiers in CLI commands

active_tcp_test.go

@@ -147,7 +147,7 @@ func TestActiveTCP(t *testing.T) {
 			req.NoError(err)
 			req.NotNil(activeAgent)
 
-			passiveAgentConn, activeAgenConn := connect(passiveAgent, activeAgent)
+			passiveAgentConn, activeAgenConn := connect(t, passiveAgent, activeAgent)
 			req.NotNil(passiveAgentConn)
 			req.NotNil(activeAgenConn)
 
@@ -220,7 +220,7 @@ func TestActiveTCP_NonBlocking(t *testing.T) {
 	require.NoError(t, aAgent.AddRemoteCandidate(invalidCandidate))
 	require.NoError(t, bAgent.AddRemoteCandidate(invalidCandidate))
 
-	connect(aAgent, bAgent)
+	connect(t, aAgent, bAgent)
 
 	<-isConnected
 }
@@ -284,7 +284,7 @@ func TestActiveTCP_Respect_NetworkTypes(t *testing.T) {
 	require.NoError(t, aAgent.AddRemoteCandidate(invalidCandidate))
 	require.NoError(t, bAgent.AddRemoteCandidate(invalidCandidate))
 
-	connect(aAgent, bAgent)
+	connect(t, aAgent, bAgent)
 
 	<-isConnected
 	require.NoError(t, tcpListener.Close())

agent_handlers_test.go

@@ -8,6 +8,7 @@ import (
 	"time"
 
 	"github.com/pion/transport/v3/test"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestConnectionStateNotifier(t *testing.T) {
@@ -33,7 +34,7 @@ func TestConnectionStateNotifier(t *testing.T) {
 			}
 			select {
 			case <-updates:
-				t.Errorf("received more updates than expected")
+				t.Errorf("received more updates than expected") // nolint
 			case <-time.After(1 * time.Second):
 			}
 			close(done)
@@ -53,14 +54,11 @@ func TestConnectionStateNotifier(t *testing.T) {
 		done := make(chan struct{})
 		go func() {
 			for i := 0; i < 10000; i++ {
-				x := <-updates
-				if x != ConnectionState(i) {
-					t.Errorf("expected %d got %d", x, i)
-				}
+				assert.Equal(t, ConnectionState(i), <-updates)
 			}
 			select {
 			case <-updates:
-				t.Errorf("received more updates than expected")
+				t.Errorf("received more updates than expected") // nolint
 			case <-time.After(1 * time.Second):
 			}
 			close(done)