test(fix): destroy the default integration before testing #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdstein
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors tests to use dynamically generated identifiers instead of hardcoded values, preventing collisions in integration test runs.
- Introduces a new
fixtures.pymodule for generating unique names, emails, usernames, and passwords. - Updates all integration tests (and one production method) to pull values from
fixturesrather than literals. - Tweaks client test assertions to use the
MockSessionreturn value.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/posit/connect/test_hooks.py | Expanded the deprecation warning match parameter |
| tests/posit/connect/test_client.py | Updated session call assertions to use MockSession |
| src/posit/connect/users.py | Replaced hardcoded password with fixtures.password() |
| integration/tests/posit/connect/fixtures.py | Added fixtures module for unique test data |
| integration/tests/posit/connect/***.py | Replaced literal test data with calls to fixtures |
Comments suppressed due to low confidence (2)
src/posit/connect/users.py:365
- The code now references
fixtures.password()butfixturesis not imported—addfrom posit.connect.tests.fixtures import password, name, email, username(or the correct import path) at the top of this file.
... password=fixtures.password(),
integration/tests/posit/connect/test_system.py:44
Pathis used here but not imported—addfrom pathlib import Pathnear the top of this test file.
path = (Path(__file__).parent / path).resolve()
tdstein
changed the title
cgraham-rs
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in 2025.05.0, a default integration is created by Connect. We want to destroy that integration before running the test suite.