Make invocation question less misleading.

format using prettier.

Reset unneccesary changes to agent prompt

Move _last_ code inside of positron fence

Fix comma splice and improve package install confirmation message

Fix prettier formatting in commands.ts

Author: nstrayer

extensions/positron-assistant/src/md/prompts/chat/agent.md

@@ -13,7 +13,6 @@ You ONLY use the execute code tool as a way to learn about the environment as a
 The execute code tool runs code in the currently active session(s). You do not try to execute any other programming language.
 
 You NEVER try to start a Shiny app using the execute code tool, even if the user explicitly asks. You are unable to start a Shiny app in this way.
-
 </tools>
 
 <communication>
@@ -22,6 +21,8 @@ results, generate the code and return it directly without trying to execute it.
 </communication>
 
 <package-management>
+You adhere to the following workflow when dealing with package management:
+
 **Package Management Workflow:**
 
 1. Before generating code that requires packages, you must first use the appropriate tool to check if each required package is installed. To do so, first determine the target language from the user's request or context

extensions/positron-assistant/src/tools.ts

@@ -289,11 +289,16 @@ export function registerAssistantTools(
 		prepareInvocation2: async (options, _token) => {
 			const packageNames = options.input.packages.join(', ');
 			const result: vscode.PreparedTerminalToolInvocation = {
-				command: `pip install ${options.input.packages.join(' ')}`,
-				language: 'bash',
+				// Display a generic command description rather than a specific pip command
+				// The actual implementation uses environment-aware package management (pip, conda, poetry, etc.)
+				// via the Python extension's installPackages command, not direct pip execution
+				command: `Install Python packages: ${packageNames}`,
+				language: 'text', // Not actually a bash command
 				confirmationMessages: {
 					title: vscode.l10n.t('Install Python Packages'),
-					message: vscode.l10n.t('Positron Assistant wants to install {0}, is this okay?', packageNames)
+					message: options.input.packages.length === 1
+						? vscode.l10n.t('Positron Assistant wants to install the package {0}. Is this okay?', packageNames)
+						: vscode.l10n.t('Positron Assistant wants to install the following packages: {0}. Is this okay?', packageNames)
 				},
 			};
 			return result;

extensions/positron-python/src/client/common/application/commands.ts

@@ -56,18 +56,17 @@ export type AllCommands = keyof ICommandNameArgumentTypeMapping;
  */
 export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgumentTypeMapping {
     [Commands.Create_Environment]: [CreateEnvironmentOptions];
-    [Commands.InstallPackages]: [string[]];
     ['vscode.openWith']: [Uri, string];
     ['workbench.action.quickOpen']: [string];
     ['workbench.action.openWalkthrough']: [string | { category: string; step: string }, boolean | undefined];
     ['workbench.extensions.installExtension']: [
         Uri | string,
         (
             | {
-                installOnlyNewlyAddedFromExtensionPackVSIX?: boolean;
-                installPreReleaseVersion?: boolean;
-                donotSync?: boolean;
-            }
+                  installOnlyNewlyAddedFromExtensionPackVSIX?: boolean;
+                  installPreReleaseVersion?: boolean;
+                  donotSync?: boolean;
+              }
             | undefined
         ),
     ];
@@ -112,6 +111,7 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu
     [Commands.Exec_In_Console]: [];
     [Commands.Focus_Positron_Console]: [];
     [Commands.Create_Pyproject_Toml]: [string | undefined];
+    [Commands.InstallPackages]: [string[]];
     // --- End Positron ---
     [Commands.Tests_Configure]: [undefined, undefined | CommandSource, undefined | Uri];
     [Commands.Tests_CopilotSetup]: [undefined | Uri];

extensions/positron-python/src/client/common/application/commands/installPackages.ts

@@ -13,65 +13,63 @@ import { Product } from '../../types';
 
 @injectable()
 export class InstallPackagesCommandHandler implements IExtensionSingleActivationService {
-	public readonly supportedWorkspaceTypes = { untrustedWorkspace: false, virtualWorkspace: false };
+    public readonly supportedWorkspaceTypes = { untrustedWorkspace: false, virtualWorkspace: false };
 
-	constructor(
-		@inject(ICommandManager) private readonly commandManager: ICommandManager,
-		@inject(IInstallationChannelManager) private readonly channelManager: IInstallationChannelManager,
-		@inject(IDisposableRegistry) private readonly disposables: IDisposableRegistry,
-	) { }
+    constructor(
+        @inject(ICommandManager) private readonly commandManager: ICommandManager,
+        @inject(IInstallationChannelManager) private readonly channelManager: IInstallationChannelManager,
+        @inject(IDisposableRegistry) private readonly disposables: IDisposableRegistry,
+    ) {}
 
-	public async activate(): Promise<void> {
-		this.disposables.push(
-			this.commandManager.registerCommand(Commands.InstallPackages, this.installPackages, this)
-		);
-	}
+    public async activate(): Promise<void> {
+        this.disposables.push(
+            this.commandManager.registerCommand(Commands.InstallPackages, this.installPackages, this),
+        );
+    }
 
-	/**
-	 * Installs Python packages using the appropriate package manager for the current environment.
-	 * @param packages Array of package names to install
-	 * @returns Promise resolving to array of installation result messages
-	 * @throws Error with prefixed error codes for structured error handling:
-	 *   - `[NO_INSTALLER]` - No compatible package installer found for environment
-	 *   - `[VALIDATION_ERROR]` - Invalid or missing package names provided
-	 *   - Other errors may be thrown by underlying installation system without prefixes
-	 */
-	public async installPackages(
-		packages: string[]
-	): Promise<string[]> {
-		// Input validation
-		if (!packages || packages.length === 0) {
-			throw new Error('[VALIDATION_ERROR] At least one package name must be provided');
-		}
+    /**
+     * Installs Python packages using the appropriate package manager for the current environment.
+     * @param packages Array of package names to install
+     * @returns Promise resolving to array of installation result messages
+     * @throws Error with prefixed error codes for structured error handling:
+     *   - `[NO_INSTALLER]` - No compatible package installer found for environment
+     *   - `[VALIDATION_ERROR]` - Invalid or missing package names provided
+     *   - Other errors may be thrown by underlying installation system without prefixes
+     */
+    public async installPackages(packages: string[]): Promise<string[]> {
+        // Input validation
+        if (!packages || packages.length === 0) {
+            throw new Error('[VALIDATION_ERROR] At least one package name must be provided');
+        }
 
-		const invalidPackages = packages.filter(pkg => !pkg || typeof pkg !== 'string' || pkg.trim().length === 0);
-		if (invalidPackages.length > 0) {
-			throw new Error('[VALIDATION_ERROR] All package names must be non-empty strings');
-		}
-		const results: string[] = [];
+        const invalidPackages = packages.filter((pkg) => !pkg || typeof pkg !== 'string' || pkg.trim().length === 0);
+        if (invalidPackages.length > 0) {
+            throw new Error('[VALIDATION_ERROR] All package names must be non-empty strings');
+        }
+        const results: string[] = [];
 
-		// Get installer once upfront to avoid repeated calls
-		const installer = await this.channelManager.getInstallationChannel(Product.pip, undefined);
-		if (!installer) {
-			throw new Error('[NO_INSTALLER] No compatible package installer found for current environment');
-		}
+        // Get installer once upfront to avoid repeated calls
+        const installer = await this.channelManager.getInstallationChannel(Product.pip, undefined);
+        if (!installer) {
+            throw new Error('[NO_INSTALLER] No compatible package installer found for current environment');
+        }
 
-		// Process each package individually, continuing on failures
-		// Note: We don't throw on individual package failures because:
-		// 1. The Assistant can intelligently parse mixed success/failure results
-		// 2. Partial success is often valuable (e.g., pandas works even if matplotlib fails)
-		// 3. Detailed per-package feedback helps the Assistant make better decisions
-		for (const packageName of packages) {
-			try {
-				await installer.installModule(packageName, undefined, undefined, ModuleInstallFlags.none, undefined);
-				results.push(`${packageName} installed successfully using ${installer.displayName}`);
-			} catch (error) {
-				const errorMsg = error instanceof Error ? error.message : String(error);
-				results.push(`${packageName}: Installation failed - ${errorMsg}`);
-				// Continue with next package to provide complete installation report
-			}
-		}
+        // Process each package individually, continuing on failures
+        // Note: We don't throw on individual package failures because:
+        // 1. The Assistant can intelligently parse mixed success/failure results
+        // 2. Partial success is often valuable (e.g., pandas works even if matplotlib fails)
+        // 3. Detailed per-package feedback helps the Assistant make better decisions
+        for (const packageName of packages) {
+            try {
+                await installer.installModule(packageName, undefined, undefined, ModuleInstallFlags.none, undefined);
+                results.push(`${packageName} installed successfully using ${installer.displayName}`);
+            } catch (error) {
+                const errorMsg = error instanceof Error ? error.message : String(error);
+                results.push(`${packageName}: Installation failed - ${errorMsg}`);
+                // Continue with next package to provide complete installation report
+            }
+        }
 
-		return results;
-	}
+        return results;
+    }
 }