E2E test: use docker image (#8694)

Add docker images to CI workflow for Ubuntu. This decreases the average
test execution time by 5-10 minutes. Dockerfiles are at [Positron CI
Images](https://github.com/posit-dev/positron-ci-images). This repo is
private so authentication is required. Note that integration tests now
also use a container, but unit tests do not yet.

In docker, the tests run as root, as required according to [Github
Documentation](https://docs.github.com/en/actions/reference/workflows-and-actions/dockerfile-support).
This has necessitated some changes:
* python interpreters now must be on the include list. This is
accomplished by having a separate settingsDocker.json file which is
merged with settings.json for docker runs.
* some tests now have different "expected" or configuration paths.

### QA Notes

@:web @:connections @:quarto @:test-explorer

Author: testlabauto

.github/actions/setup-build-env/action.yml

@@ -3,39 +3,13 @@ description: "Installs necessary system dependencies."
 runs:
   using: "composite"
   steps:
-    - name: Install Build Dependencies
-      shell: bash
-      run: |
-        # Detect Ubuntu version
-        UBUNTU_VERSION=$(lsb_release -rs)
-        echo "Running on Ubuntu version: $UBUNTU_VERSION"
-
-        # Install libasound2 or libasound2t64 based on version
-        if [[ "$UBUNTU_VERSION" == "24.04" ]]; then
-          echo "Installing libasound2t64 for Ubuntu 24.04"
-          sudo apt-get update
-          sudo apt-get install -y libasound2t64
-        else
-          echo "Installing libasound2 for older Ubuntu versions"
-          sudo apt-get update
-          sudo apt-get install -y libasound2
-        fi
-        sudo apt-get install -y \
-          vim curl build-essential clang make cmake git \
-          libsodium-dev libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb \
-          libgtk-3-0 libgbm1 libnss3 libnspr4 libkrb5-dev libcairo-dev \
-          libsdl-pango-dev libjpeg-dev libgif-dev pandoc libgtk-4-1
-
     - name: Install Node packages
       shell: bash
       env:
         PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
         ELECTRON_SKIP_BINARY_DOWNLOAD: 1
         POSITRON_GITHUB_PAT: ${{ github.token }}
       run: |
-        # Install node-gyp; this is required by some packages
-        npm i --global node-gyp
-
         # Perform the main npm command; this installs all Node packages and
         # dependencies
         npm ci --fetch-timeout 120000
@@ -53,15 +27,6 @@ runs:
         sudo chmod 4755 $ELECTRON_ROOT/chrome-sandbox
         stat $ELECTRON_ROOT/chrome-sandbox
 
-    # Although not directly part of the build environment, this configuration is essential for running unit, integration, and e2e tests.
-    - name: Configure xvfb Service
-      shell: bash
-      run: |
-        sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb
-        sudo chmod +x /etc/init.d/xvfb
-        sudo update-rc.d xvfb defaults
-        sudo service xvfb start
-
     # Downloads Builtin Extensions (needed for integration & e2e testing)
     - shell: bash
       run: npm run prelaunch

.github/actions/setup-test-env/action.yml

@@ -7,12 +7,7 @@ inputs:
   aws-region:
     description: "The AWS region for S3"
     required: true
-  github-token:
-    description: "GitHub Token for accessing private repositories or APIs"
-    required: true
-  install_undetectable_interpreters:
-    description: "Install undetectable interpreters"
-    required: true
+
 runs:
   using: "composite"
   steps:
@@ -26,35 +21,5 @@ runs:
         role-to-assume: ${{ inputs.aws-role-to-assume }}
         aws-region: ${{ inputs.aws-region }}
 
-    - name: Setup Graphviz
-      uses: ts-graphviz/setup-graphviz@v2.0.2
-
-    - name: Setup Quarto
-      uses: quarto-dev/quarto-actions/setup@v2
-      env:
-        GH_TOKEN: ${{ inputs.github-token }}
-      with:
-        tinytex: true
-
-    # Miniforge avoids Anaconda ToS and defaults to conda-forge
-    - name: Setup Conda (Miniforge3)
-      uses: conda-incubator/setup-miniconda@v3
-      with:
-        miniforge-version: latest
-        auto-activate-base: false
-        channels: conda-forge,defaults  # Defaults included only to suppress warnings; all packages are still resolved from conda-forge
-        conda-remove-defaults: "true"
-        channel-priority: strict
-
-    - name: Setup Python
-      uses: ./.github/actions/install-python
-      with:
-        alternate_version: "3.13.0"
-        install_undetectable_interpreters: ${{ inputs.install_undetectable_interpreters }}
-
-    - name: Setup R
-      uses: ./.github/actions/install-r
-      with:
-        version: "4.4.0"
-        alternate_version: "4.4.2"
-        install_undetectable_interpreters: ${{ inputs.install_undetectable_interpreters }}
+    - name: Setup Xvfb
+      uses: ./.github/actions/setup-xvfb

.github/actions/setup-unit-test-build-env/action.yml

@@ -0,0 +1,67 @@
+name: "Setup Build Environment, Install Dependencies, and Compile App"
+description: "Installs necessary system dependencies."
+runs:
+  using: "composite"
+  steps:
+    - name: Install Build Dependencies
+      shell: bash
+      run: |
+        # Detect Ubuntu version
+        UBUNTU_VERSION=$(lsb_release -rs)
+        echo "Running on Ubuntu version: $UBUNTU_VERSION"
+
+        # Install libasound2 or libasound2t64 based on version
+        if [[ "$UBUNTU_VERSION" == "24.04" ]]; then
+          echo "Installing libasound2t64 for Ubuntu 24.04"
+          sudo apt-get update
+          sudo apt-get install -y libasound2t64
+        else
+          echo "Installing libasound2 for older Ubuntu versions"
+          sudo apt-get update
+          sudo apt-get install -y libasound2
+        fi
+        sudo apt-get install -y \
+          vim curl build-essential clang make cmake git \
+          libsodium-dev libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb \
+          libgtk-3-0 libgbm1 libnss3 libnspr4 libkrb5-dev libcairo-dev \
+          libsdl-pango-dev libjpeg-dev libgif-dev pandoc libgtk-4-1
+
+    - name: Install Node packages
+      shell: bash
+      env:
+        PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+        ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+        POSITRON_GITHUB_PAT: ${{ github.token }}
+      run: |
+        # Install node-gyp; this is required by some packages
+        npm i --global node-gyp
+
+        # Perform the main npm command; this installs all Node packages and
+        # dependencies
+        npm ci --fetch-timeout 120000
+        npm --prefix test/e2e ci
+
+    - name: Compile and Download
+      shell: bash
+      run: npm exec -- npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install
+
+    - name: Set permissions on SUID sandbox helper
+      shell: bash
+      run: |
+        ELECTRON_ROOT=.build/electron
+        sudo chown root $ELECTRON_ROOT/chrome-sandbox
+        sudo chmod 4755 $ELECTRON_ROOT/chrome-sandbox
+        stat $ELECTRON_ROOT/chrome-sandbox
+
+    # Although not directly part of the build environment, this configuration is essential for running unit, integration, and e2e tests.
+    - name: Configure xvfb Service
+      shell: bash
+      run: |
+        sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb
+        sudo chmod +x /etc/init.d/xvfb
+        sudo update-rc.d xvfb defaults
+        sudo service xvfb start
+
+    # Downloads Builtin Extensions (needed for integration & e2e testing)
+    - shell: bash
+      run: npm run prelaunch

.github/actions/setup-xvfb/action.yml

@@ -0,0 +1,25 @@
+name: "Setup Xvfb"
+description: "Configure and start Xvfb virtual framebuffer"
+
+runs:
+  using: "composite"
+  steps:
+    - name: Setup Xvfb
+      shell: bash
+      run: |
+        # Start Xvfb in the background
+        /usr/bin/Xvfb :10 -ac -screen 0 2560x1440x24 > /tmp/Xvfb.out 2>&1 &
+
+        # Wait until Xvfb is ready
+        export DISPLAY=:10
+        for i in {1..10}; do
+          if xdpyinfo > /dev/null 2>&1; then
+            echo "Xvfb is ready"
+            break
+          fi
+          echo "Waiting for Xvfb to start..."
+          sleep 1
+        done
+
+        # Export the DISPLAY variable for subsequent steps
+        echo "DISPLAY=:10" >> $GITHUB_ENV

.github/workflows/test-e2e-ubuntu.yml

@@ -57,7 +57,7 @@ on:
         required: false
         description: "Whether or not to upload e2e test logs."
         type: boolean
-        default: false
+        default: true
 
   workflow_dispatch:
     inputs:
@@ -83,15 +83,27 @@ on:
 permissions:
   id-token: write
   contents: read
+  packages: read
 
 jobs:
+
   e2e-linux:
     name: ${{ inputs.display_name || 'e2e-linux' }}
     timeout-minutes: 120
     runs-on: ubuntu-latest-8x
+    container:
+      image: ghcr.io/posit-dev/positron-ubuntu24-amd64:21
+      options: --user 0:0
+      # Static PAT is needed because the bot can't pass a token to the job for security reasons
+      credentials:
+        username: ${{ secrets.POSITRON_GITHUB_USER }}
+        password: ${{ secrets.POSITRON_GITHUB_PAT }}
     services:
       postgres:
-        image: postgres:latest
+        image: ghcr.io/posit-dev/positron-postgres-initialized:21
+        credentials:
+          username: ${{ secrets.POSITRON_GITHUB_USER }}
+          password: ${{ secrets.POSITRON_GITHUB_PAT }}
         ports:
           - 5432:5432
         env:
@@ -111,6 +123,8 @@ jobs:
       E2E_POSTGRES_DB: ${{ secrets.E2E_POSTGRES_DB }}
       E2E_CONNECT_SERVER: ${{ secrets.E2E_CONNECT_SERVER}}
       E2E_CONNECT_APIKEY: ${{ secrets.E2E_CONNECT_APIKEY}}
+      R_LIBS_SITE: /usr/local/lib/R/site-library
+      R_LIBS_USER: /usr/local/lib/R/site-library
     steps:
       - uses: actions/checkout@v4
 
@@ -123,31 +137,10 @@ jobs:
           OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
           ANTHROPIC_API_KEY: "op://Positron/Anthropic/credential"
 
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: .nvmrc
-
-      - name: Download sample database
-        run: |
-          wget https://raw.githubusercontent.com/neondatabase/postgres-sample-dbs/main/periodic_table.sql
-
-      - name: Connect to PostgreSQL and load sample data
-        env:
-          PGHOST: localhost
-          PGPORT: 5432
-          PGUSER: ${{ secrets.E2E_POSTGRES_USER }}
-          PGPASSWORD: ${{ secrets.E2E_POSTGRES_PASSWORD }}
-          PGDATABASE: ${{ secrets.E2E_POSTGRES_DB }}
-        run: |
-          psql -v ON_ERROR_STOP=1 -f periodic_table.sql
-
       - name: Transform to Playwright tags $PW_TAGS
         run: bash scripts/pr-tags-transform.sh ${{ inputs.project}} "${{ inputs.grep }}"
         shell: bash
 
-      - name: Cache node_modules, build, extensions, and remote
-        uses: ./.github/actions/cache-multi-paths
-
       - name: Attempt 1 - Setup Build and Compile
         id: attempt1
         uses: ./.github/actions/setup-build-env
@@ -180,8 +173,6 @@ jobs:
         with:
           aws-role-to-assume: ${{ secrets.QA_AWS_RO_ROLE }}
           aws-region: ${{ secrets.QA_AWS_REGION }}
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          install_undetectable_interpreters: ${{ inputs.install_undetectable_interpreters }}
 
       # Preloading ensures the Node.js binary is fully built and ready before
       # any parallel processes start, preventing runtime conflicts
@@ -196,10 +187,11 @@ jobs:
         run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
 
       - name: Run Playwright Tests (Electron)
+        shell: bash
         env:
-          POSITRON_PY_VER_SEL: 3.12.6
+          POSITRON_PY_VER_SEL: "3.12.11 (Venv: .venv)"
           POSITRON_R_VER_SEL: 4.4.0
-          POSITRON_PY_ALT_VER_SEL: "3.13.0 (Pyenv)"
+          POSITRON_PY_ALT_VER_SEL: "3.13.0"
           POSITRON_R_ALT_VER_SEL: 4.4.2
           POSITRON_HIDDEN_PY: "3.12.10 (Conda)"
           POSITRON_HIDDEN_R: 4.4.1
@@ -249,12 +241,12 @@ jobs:
           echo "Final --grep-invert argument: $GREP_INVERT_ARG"
 
           # Don't run this test in parallel & don't allow skipping it
-          echo "Running: DISPLAY=:10 npx playwright test test/e2e/tests/extensions/bootstrap-extensions.test.ts --project ${{ inputs.project }} --reporter=null"
-          DISPLAY=:10 npx playwright test test/e2e/tests/extensions/bootstrap-extensions.test.ts --project ${{ inputs.project }} --reporter=null
+          echo "Running: npx playwright test test/e2e/tests/extensions/bootstrap-extensions.test.ts --project ${{ inputs.project }} --reporter=null"
+          npx playwright test test/e2e/tests/extensions/bootstrap-extensions.test.ts --project ${{ inputs.project }} --reporter=null
 
           # Run the Playwright test command directly using eval
-          echo "Running: DISPLAY=:10 npx playwright test --project ${{ inputs.project }} --workers 2 $GREP_ARG $GREP_INVERT_ARG --repeat-each ${{ inputs.repeat_each }} --max-failures 10"
-          eval DISPLAY=:10 SKIP_BOOTSTRAP=true SKIP_CLONE=true npx playwright test --project ${{ inputs.project }} --workers 2 $GREP_ARG $GREP_INVERT_ARG --repeat-each ${{ inputs.repeat_each }} --max-failures 10
+          echo "Running: npx playwright test --project ${{ inputs.project }} --workers 2 $GREP_ARG $GREP_INVERT_ARG --repeat-each ${{ inputs.repeat_each }} --max-failures 10"
+          eval SKIP_BOOTSTRAP=true SKIP_CLONE=true npx playwright test --project ${{ inputs.project }} --workers 2 $GREP_ARG $GREP_INVERT_ARG --repeat-each ${{ inputs.repeat_each }} --max-failures 10
 
       - name: Upload Playwright Report to S3
         if: ${{ success() || failure() }}
@@ -263,28 +255,10 @@ jobs:
           role-to-assume: ${{ secrets.AWS_TEST_REPORTS_ROLE }}
           report-dir: ${{ env.REPORT_DIR }}
 
-      - name: Install trcli
-        if: ${{ inputs.report_testrail }}
-        shell: bash
-        run: sudo apt-get update && sudo apt-get install -y python3-pip && pip3 install trcli
-
-      - name: Upload Test Results to TestRail
-        if: ${{ inputs.report_testrail }}
-        shell: bash
-        run: |
-          TESTRAIL_TITLE="$(date +'%Y-%m-%d') ${{ env.TESTRAIL_TITLE }} - $GITHUB_REF_NAME"
-          echo "TESTRAIL_TITLE=$TESTRAIL_TITLE" >> $GITHUB_ENV
-          trcli --host "https://posit.testrail.io/" --project "${{ env.TESTRAIL_PROJECT }}" --username testrailautomation@posit.co --key "${{ env.TESTRAIL_API_KEY }}" parse_junit --file "./test-results/junit.xml" --case-matcher name --title "$TESTRAIL_TITLE" --close-run
-        env:
-          TESTRAIL_TITLE: ${{ inputs.project }}
-          TESTRAIL_PROJECT: "Positron"
-          TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }}
-
       - name: Upload Test Logs
         if: ${{ always() && inputs.upload_logs }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ inputs.project }}-logs
           path: test-logs
           if-no-files-found: ignore
-

.github/workflows/test-integration.yml

@@ -22,6 +22,12 @@ jobs:
   integration-tests:
     name: integration
     runs-on: ubuntu-latest-4x
+    container:
+      image: ghcr.io/posit-dev/positron-ubuntu24-amd64:21
+      options: --user 0:0
+      credentials:
+        username: ${{ secrets.POSITRON_GITHUB_USER }}
+        password: ${{ secrets.POSITRON_GITHUB_PAT }}
     timeout-minutes: 40
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -64,9 +70,8 @@ jobs:
           github-token: ${{ secrets.POSITRON_GITHUB_PAT }}
           license-key: ${{ secrets.POSITRON_DEV_LICENSE }}
 
-      # one integration test needs this: Connections pane works for R
-      - name: Setup R
-        uses: ./.github/actions/install-r
+      - name: Setup XVFB
+        uses: ./.github/actions/setup-xvfb
         with:
             version: "4.4.0"