fix(tests): Add missing env vars for shinyapps.io tests (#1663)

Author: karangattu

.github/workflows/deploy-tests.yaml

@@ -64,6 +64,7 @@ jobs:
             pypi_shiny: false
             pypi_rsconnect: false
             base_test_dir: "./tests/playwright/deploys"
+            app_name: "express_page_sidebar"
             test_shinyappsio: true
 
       fail-fast: false
@@ -110,9 +111,9 @@ jobs:
           DEPLOY_APPS: "true"
           DEPLOY_CONNECT_SERVER_URL: "${{ (matrix.config.released_connect_server && 'https://connect.posit.it/') || 'https://rsc.radixu.com/' }}"
           DEPLOY_CONNECT_SERVER_API_KEY: "${{ (matrix.config.released_connect_server && secrets.DEPLOY_CONNECT_POSIT_SERVER_API_KEY) || secrets.DEPLOY_CONNECT_SERVER_API_KEY }}"
-          DEPLOY_SHINYAPPS_NAME: "${{ matrix.config.test_shinyappsio && matrix.config.shinyapps_name }}"
-          DEPLOY_SHINYAPPS_TOKEN: "${{ matrix.config.test_shinyappsio && matrix.config.shinyapps_token }}"
-          DEPLOY_SHINYAPPS_SECRET: "${{ matrix.config.test_shinyappsio && matrix.config.shinyapps_secret }}"
+          DEPLOY_SHINYAPPS_NAME: "${{ matrix.config.test_shinyappsio && secrets.DEPLOY_SHINYAPPS_NAME }}"
+          DEPLOY_SHINYAPPS_TOKEN: "${{ matrix.config.test_shinyappsio && secrets.DEPLOY_SHINYAPPS_TOKEN }}"
+          DEPLOY_SHINYAPPS_SECRET: "${{ matrix.config.test_shinyappsio && secrets.DEPLOY_SHINYAPPS_SECRET }}"
           EXPRESS_PAGE_SIDEBAR_NAME: "${{ matrix.config.app_name }}"
           DEPLOY_GITHUB_REQUIREMENTS_TXT: "${{ !matrix.config.pypi_shiny }}"
         timeout-minutes: 30

tests/playwright/deploys/express-page_sidebar/test_deploys_express_page_sidebar.py

@@ -13,7 +13,8 @@
 
 app_url = local_deploys_app_url_fixture(
     # Possibly use a different app name given by an GHA env var
-    os.getenv("EXPRESS_PAGE_SIDEBAR_NAME", "express_page_sidebar")
+    os.getenv("EXPRESS_PAGE_SIDEBAR_NAME")
+    or "express_page_sidebar"
 )