-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
I tried to use the action and I initially failed. This was my reasoning:
- I was reading the
README
from here and I saw this part:
Before using this action, ensure that you've locally run Air on your entire project at least once using
air format .
or theAir: Format Workspace Folder
command in VS Code or Positron, otherwise you can end up with a very large amount of suggestions.
- I ran
air format .
locally, and I saw that in fact it detected not too many changes, so I felt the above clarification was unnecessary in my case and I could handle this directly through committing the bot suggestions in the PR. - I created a PR expecting to see the bot suggestions but the
format-suggest.yaml
workflow ended correctly and nothing showed up. - I tried to push a dummy change and in this case the suggestion did show up, but only for this small change.
- I realised the suggestions only appear for code that was changed in that same PR, not all the code. I don't know how the action really works so I can't tell if this is just a default, but it was confusing for me.
Leaving this here in case this happens to someone else.
Also my attempts through the steps above if it helps eduaguilera/whep#49.
Metadata
Metadata
Assignees
Labels
No labels