Skip to content

Commit 83da4fe

Browse files
committed
update tests for new icon
1 parent 2a69be9 commit 83da4fe

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/jupyter_matlab_proxy/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ def setup_matlab():
3838
logger = mwi_logger.get(init=True)
3939
logger.info("Initializing Jupyter MATLAB Proxy")
4040

41-
# Get MATLAB icon from matlab_proxy
42-
#package_path = Path(inspect.getfile(matlab_proxy)).parent
43-
#icon_path = package_path / "icons" / "matlab.svg"
4441
icon_path = Path(__file__).parent / "icon_open_matlab.svg"
4542
logger.debug(f"Icon_path: {icon_path}")
4643
logger.debug(f"Launch Command: {matlab_proxy.get_executable_name()}")

tests/test_jupyter_server_proxy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ def test_setup_matlab():
2424
Dictionary for the Matlab process.
2525
"""
2626
# Setup
27-
package_path = Path(inspect.getfile(matlab_proxy)).parent
28-
icon_path = package_path / "icons" / "matlab.svg"
27+
package_path = Path(inspect.getfile(jupyter_matlab_proxy)).parent
28+
icon_path = package_path / "icon_open_matlab.svg"
2929

3030
expected_matlab_setup = {
3131
"command": [
@@ -37,7 +37,7 @@ def test_setup_matlab():
3737
"environment": jupyter_matlab_proxy._get_env,
3838
"absolute_url": True,
3939
"launcher_entry": {
40-
"title": "MATLAB",
40+
"title": "Open MATLAB",
4141
"icon_path": icon_path,
4242
},
4343
}

0 commit comments

Comments
 (0)