-
-
Notifications
You must be signed in to change notification settings - Fork 118
Fix props issue with storybook #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +24 B (+0.02%) Total Size: 99.4 kB
ℹ️ View Unchanged
|
Fixes #775
The problem is the following
and we recurse further
The solution here is to access
.valueto return a plain value.EDIT: hah, looks like tests won't pass as we're relying on react accessing this property later when the sync-external-store runs
EDIT 2: attempt 2 doesn't work either as react will bail for these strict equal props 😅 this is a bit of a pickle