Skip to content

Correct cached vs non-cached shape #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Correct cached vs non-cached shape #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba3540
Correct cached vs non-cached shape
JoviDeCroock Nov 6, 2025
cf673c5
Merge branch 'main' into correct-result-setting
JoviDeCroock Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/slow-dolphins-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@preact/signals-react": patch
"@preact/signals": patch
---

Ensure the cached and non-cached shape is the same
15 changes: 6 additions & 9 deletions packages/preact/utils/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,9 @@ interface ShowProps<T = boolean> {
}

const Item = (props: any) => {
const result =
typeof props.children === "function"
? props.children(props.v, props.i)
: props.children;
if (props.cache) {
props.cache.set(props.v, result);
}
return result;
return typeof props.children === "function"
? props.children(props.v, props.i)
: props.children;
};

export function Show<T = boolean>(props: ShowProps<T>): JSX.Element | null {
Expand Down Expand Up @@ -48,7 +43,9 @@ export function For<T>(props: ForProps<T>): JSX.Element | null {

const items = list.map((value, key) => {
if (!cache.has(value)) {
return <Item v={value} i={key} children={props.children} cache={cache} />;
const result = <Item v={value} i={key} children={props.children} />;
cache.set(value, result);
return result;
}
return cache.get(value);
});
Expand Down
23 changes: 7 additions & 16 deletions packages/react/utils/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,9 @@ interface ShowProps<T = boolean> {

const Item = (props: any) => {
useSignals();
const result =
typeof props.children === "function"
? props.children(props.v, props.i)
: props.children;
if (props.cache) {
props.cache.set(props.v, result);
}
return result;
return typeof props.children === "function"
? props.children(props.v, props.i)
: props.children;
};

export function Show<T = boolean>(props: ShowProps<T>): JSX.Element | null {
Expand Down Expand Up @@ -51,15 +46,11 @@ export function For<T>(props: ForProps<T>): JSX.Element | null {

const items = list.map((value, key) => {
if (!cache.has(value)) {
return (
<Item
v={value}
key={key}
i={key}
children={props.children}
cache={cache}
/>
const result = (
<Item v={value} key={key} i={key} children={props.children} />
);
cache.set(value, result);
return result;
}
return cache.get(value);
});
Expand Down