Skip to content

pr05 Typescript #2: automatically resolve imports of ts files & migrate instance of client/utils file #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Jul 15, 2025

pr05 Typescript Migration: Auto-resolve import of ts files & migrate instance of client/utils file

IMPORTANT: Should be reviewed after #3533 for clarity

Context:

  • Resolve issue with needing to update import extensions (eg. from js to ts), so that ts imports automatically resolve for both the client folder & tests
    • Not sure if this resolves imports for the server folder yet -- will resolve this on the PR to migrate an instance of a server file later if so
  • Migrate instance of a client/utils file

Changes:

  • Auto-resolve imports for local instance of project client folder
  • Auto-resolve imports for jest tests
  • Migrate client/utils/generateRandomName & associated mock
  • Delete client/utils/isSecurePage -- checked and this utility function is unused in the project

Notes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

clairep94 and others added 30 commits July 6, 2025 15:01
@clairep94 clairep94 marked this pull request as ready for review July 16, 2025 19:02
@clairep94
Copy link
Collaborator Author

clairep94 commented Jul 16, 2025

@khanniie @raclim

Should be reviewed after #3533 is merged for clarity

Copy link
Collaborator

@khanniie khanniie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me so far but would love to re-approve once the first PR is in just to see the diff without the forked changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants