-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
pr05 Typescript #2: automatically resolve imports of ts files & migrate instance of client/utils file #3540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clairep94
wants to merge
34
commits into
processing:develop
Choose a base branch
from
clairep94:pr05/migrate_client_utils_instance
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pr05 Typescript #2: automatically resolve imports of ts files & migrate instance of client/utils file #3540
clairep94
wants to merge
34
commits into
processing:develop
from
clairep94:pr05/migrate_client_utils_instance
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tDate.ts is not staged
khanniie
reviewed
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me so far but would love to re-approve once the first PR is in just to see the diff without the forked changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr05 Typescript Migration: Auto-resolve import of ts files & migrate instance of client/utils file
IMPORTANT: Should be reviewed after #3533 for clarity
Context:
Changes:
client/utils/generateRandomName
& associated mockclient/utils/isSecurePage
-- checked and this utility function is unused in the projectNotes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123