Skip to content

Commit 42ad629

Browse files
committed
Added history details test ids
1 parent c3bfc67 commit 42ad629

File tree

5 files changed

+26
-19
lines changed

5 files changed

+26
-19
lines changed

app/screens/history/detail-screen.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ import { RootNavigationProp } from '../../navigators/root/root-routes';
2828
import { credentialCardLabels } from '../../utils/credential';
2929
import { nonEmptyFilter } from '../../utils/filtering';
3030
import {
31-
historyCardHeaderFromName,
3231
historyDeletedCredentialCardFromCredentialSchema,
3332
historyDeletedCredentialCardWithName,
3433
historyListItemLabels,
34+
historyProofSchemaHeader,
3535
} from '../../utils/history';
3636
import { trustEntityDetailsLabels } from '../../utils/trust-entity';
3737

@@ -171,10 +171,11 @@ export const HistoryDetailScreen: FC = () => {
171171
};
172172
} else if (entry.name) {
173173
return {
174-
credentialHeader: historyCardHeaderFromName(entry.name, 'SchemaHeader'),
174+
credentialHeader: historyProofSchemaHeader(entry.entityId, entry.name),
175175
};
176176
}
177177
}, [
178+
entry.entityId,
178179
entry.entityType,
179180
entry.name,
180181
entry.target,

app/utils/history.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,17 @@ export const historyListItemLabels: () => HistoryListItemLabels = () => ({
6262
) as { [key in keyof typeof HistoryEntityTypeEnum]: string },
6363
});
6464

65-
export const historyCardHeaderFromName = (
66-
name: string,
67-
testID?: string,
65+
export const historyProofSchemaHeader = (
66+
proofSchemaId: string | undefined,
67+
proofSchemaName: string,
6868
): CredentialHeaderProps & {
6969
onPressed?: () => void;
7070
} => {
71-
const color = schemaColorForName(name);
71+
const color = schemaColorForName(proofSchemaName);
7272
return {
7373
color,
74-
credentialName: name,
75-
testID,
74+
credentialName: proofSchemaName,
75+
testID: concatTestID('ProofSchemaHeader', proofSchemaId),
7676
};
7777
};
7878

@@ -90,7 +90,9 @@ export const historyDeletedCredentialCardWithName = (
9090
credentialDetailPrimary: translate('historyDetail.entityDeleted'),
9191
credentialName: credentialSchemaName,
9292
statusIcon: HistoryStatusDeleteIcon,
93+
testID: concatTestID('DeletedCredential', credentialId),
9394
},
95+
testID: concatTestID('DeletedCredentialCard', credentialId),
9496
},
9597
};
9698
};
@@ -114,7 +116,7 @@ export const historyDeletedCredentialCardFromCredentialSchema = (
114116
const props = detailsCardFromCredential(
115117
credential,
116118
config,
117-
concatTestID('DeletedCredential', credentialSchema.id),
119+
concatTestID('CredentialSchemaCard', credentialSchema.id),
118120
credentialCardLabels(),
119121
);
120122
return {
@@ -125,6 +127,10 @@ export const historyDeletedCredentialCardFromCredentialSchema = (
125127
...props.card.header,
126128
credentialDetailErrorColor: true,
127129
credentialDetailPrimary: translate('historyDetail.entityDeleted'),
130+
credentialDetailTestID: concatTestID(
131+
'DeletedCredential',
132+
credentialSchema.id,
133+
),
128134
statusIcon: HistoryStatusDeleteIcon,
129135
},
130136
},

ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1281,7 +1281,7 @@ PODS:
12811281
- React
12821282
- react-native-netinfo (11.4.1):
12831283
- React-Core
1284-
- react-native-one-core (1.41138.1):
1284+
- react-native-one-core (1.41710.0):
12851285
- React-Core
12861286
- react-native-picker (5.0.3):
12871287
- React-Core
@@ -2399,7 +2399,7 @@ SPEC CHECKSUMS:
23992399
react-native-get-random-values: 384787fd76976f5aec9465aff6fa9e9129af1e74
24002400
react-native-keep-awake: afad8a51dfef9fe9655a6344771be32c8596d774
24012401
react-native-netinfo: f0a9899081c185db1de5bb2fdc1c88c202a059ac
2402-
react-native-one-core: 8834c02fc875934aeb77447e52c09eb96814f65d
2402+
react-native-one-core: 1f96090814aae67e8b9e61371a72ffb1a921fe45
24032403
react-native-picker: 208cd4d747bb5088aac73c7412b07f8a1fc45902
24042404
react-native-safe-area-context: 9c33120e9eac7741a5364cc2d9f74665049b76b3
24052405
react-native-ultimate-config: bc816775e31bb2056ccfe18b49e76a5ba2d39b6c

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
},
3737
"dependencies": {
3838
"@expo/react-native-action-sheet": "^4.1.1",
39-
"@procivis/one-react-native-components": "0.3.21",
39+
"@procivis/one-react-native-components": "0.3.22",
4040
"@procivis/react-native-one-core": "1.41710.0",
4141
"@procivis/react-native-picker": "5.0.3",
4242
"@react-native-async-storage/async-storage": "^1.14.1",

pnpm-lock.yaml

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)