Skip to content

Commit a504621

Browse files
committed
Update kind tests
1 parent 08a1299 commit a504621

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

node/tests/k8st/test_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,18 +201,18 @@ def create_service(self, name, app, ns, port, svc_type="NodePort", traffic_polic
201201
logger.debug("Additional Service created. status='%s'" % str(api_response.status))
202202

203203
def wait_until_exists(self, name, resource_type, ns="default"):
204-
retry_until_success(kubectl, function_args=["get %s %s -n%s" %
204+
retry_until_success(kubectl, function_args=["get %s %s -n %s" %
205205
(resource_type, name, ns)])
206206

207207
def delete_and_confirm(self, name, resource_type, ns="default"):
208208
try:
209-
kubectl("delete %s %s -n%s" % (resource_type, name, ns))
209+
kubectl("delete %s %s -n %s" % (resource_type, name, ns))
210210
except subprocess.CalledProcessError:
211211
pass
212212

213213
def is_it_gone_yet(res_name, res_type):
214214
try:
215-
kubectl("get %s %s -n%s" % (res_type, res_name, ns),
215+
kubectl("get %s %s -n %s" % (res_type, res_name, ns),
216216
logerr=False)
217217
raise self.StillThere
218218
except subprocess.CalledProcessError:

node/tests/k8st/tests/test_local_bgp_peer.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ def setUp(self):
200200
nodeSelector: kubernetes.io/hostname == 'kind-control-plane'
201201
peerIP: %s
202202
asNumber: 63000
203+
nextHopMode: Keep
203204
filters:
204205
- export-child-cluster-cidr
205206
EOF
@@ -447,7 +448,6 @@ def test_local_bgp_peers(self):
447448
"""
448449
Runs the tests for local bgp peers
449450
"""
450-
451451
# stop_for_debug()
452452

453453
# Assert bgp sessions has been established to the following local workloads.
@@ -493,16 +493,18 @@ def test_local_bgp_peers(self):
493493

494494
if self.topology == TopologyMode.RR:
495495
# Check that the ToR hears about all the routes from master node.
496-
# 10.123.3.0/26 via 172.18.0.3 on eth0 [RR_with_master_node 14:48:19] * (100/0) [AS65401i]
497-
# 10.123.0.0/26 via 172.18.0.3 on eth0 [RR_with_master_node 14:48:18] * (100/0) [AS65401i]
498-
# 10.123.1.0/26 via 172.18.0.3 on eth0 [RR_with_master_node 14:48:19] * (100/0) [AS65401i]
496+
# Note that `nextHopMode: Keep` is specified for `rr-tor-peer`, ToR sees routes with original next hop.
497+
# 10.123.3.0/26 via 172.18.0.5 on eth0 [RR_with_master_node 09:46:12 from 172.18.0.3] * (100/0) [AS65401i]
498+
# 10.123.0.0/26 via 172.18.0.2 on eth0 [RR_with_master_node 09:46:10 from 172.18.0.3] * (100/0) [AS65401i]
499+
# 10.123.1.0/26 via 172.18.0.5 on eth0 [RR_with_master_node 09:46:12 from 172.18.0.3] * (100/0) [AS65401i]
499500
output = run("docker exec kind-node-tor birdcl show route")
500-
self.assertRegexpMatches(output, "10\.123\.0\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[0],))
501-
self.assertRegexpMatches(output, "10\.123\.1\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[0],))
502-
self.assertRegexpMatches(output, "10\.123\.3\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[0],))
501+
self.assertRegexpMatches(output, "10\.123\.0\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[1],))
502+
self.assertRegexpMatches(output, "10\.123\.1\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[2],))
503+
self.assertRegexpMatches(output, "10\.123\.3\.0/26.*via %s on .*RR_with_master_node.*AS65401" % (self.ips[2],))
503504

504505
# Check connectivity from ToR to workload.
505506
self.red_pod_0_0.execute("ip addr add 10.123.0.1 dev lo")
507+
stop_for_debug()
506508

507509
output = run("docker exec kind-node-tor ping -c3 10.123.0.1")
508510
self.assertRegexpMatches(output, "3 packets transmitted, 3 packets received")
@@ -527,7 +529,6 @@ def setUp(self):
527529
self.set_topology(TopologyMode.RR)
528530
super(TestLocalBGPPeerRR, self).setUp()
529531

530-
531532
class TestLocalBGPPeerMesh(_TestLocalBGPPeer):
532533

533534
# In the tests of this class we have BGP peers between the

0 commit comments

Comments
 (0)