Skip to content

Commit 8ca8aaa

Browse files
authored
Merge pull request #296 from projectdiscovery/dev
Bug fix for crash
2 parents cc9ee63 + 2143c56 commit 8ca8aaa

File tree

4 files changed

+21
-10
lines changed

4 files changed

+21
-10
lines changed

.github/issue-report.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,26 @@
11
---
22
name: Issue report
33
about: Create a report to help us improve
4-
title: "[issue]"
5-
labels: ''
4+
title: ""
5+
labels: 'Type:+Bug'
66
assignees: ''
77

88
---
99

1010
**Describe the bug**
1111
A clear and concise description of what the bug is.
1212

13-
**Nuclei version**
14-
Please share the version of the httpx you are running with `httpx -version`
13+
**Environment details**
14+
Please share the below details to help us quickly validate/replicate the issue.
1515

16+
- `httpx -version`
17+
- `go version`
18+
- `uname -a`
1619

17-
**Screenshot of the error or bug**
18-
please add the screenshot showing bug or issue you are facing.
20+
21+
**Error details**
22+
Please copy-paste the error trace or details from terminal to help us quickly validate/replicate the issue.
23+
24+
```bash
25+
26+
```

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ httpx is a fast and multi-purpose HTTP toolkit allow to run multiple probers usi
6262
httpx requires **go1.14+** to install successfully. Run the following command to get the repo -
6363

6464
```sh
65-
GO111MODULE=on go get -v github.com/projectdiscovery/httpx/cmd/httpx
65+
GO111MODULE=on go get -v github.com/projectdiscovery/httpx/cmd/httpx
6666
```
6767

6868
# Usage

runner/banner.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ const banner = `
88
/ __ \/ __/ __/ __ \| /
99
/ / / / /_/ /_/ /_/ / |
1010
/_/ /_/\__/\__/ .___/_/|_|
11-
/_/ v1.0.8
11+
/_/ v1.0.9
1212
`
1313

1414
// Version is the current version of httpx
15-
const Version = `v1.0.8`
15+
const Version = `v1.0.9`
1616

1717
// showBanner is used to show the banner to the user
1818
func showBanner() {

runner/runner.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,10 @@ retry:
551551
domain = parts[0]
552552
customHost = parts[1]
553553
}
554-
URL, _ := urlutil.Parse(domain)
554+
URL, err := urlutil.Parse(domain)
555+
if err != nil {
556+
return Result{URL: domain, err: err}
557+
}
555558
URL.Scheme = protocol
556559

557560
if !strings.Contains(domain, URL.Port) {

0 commit comments

Comments
 (0)