Skip to content

[Feature]: Add movement methods to AgentContainer #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamamer20 opened this issue Aug 26, 2024 · 0 comments
Open

[Feature]: Add movement methods to AgentContainer #82

adamamer20 opened this issue Aug 26, 2024 · 0 comments
Assignees
Labels
feature New functionality added to the project. good first issue Good for newcomers
Milestone

Comments

@adamamer20
Copy link
Member

adamamer20 commented Aug 26, 2024

🤔 Problem Description

Currently, various movement methods (move_to_empty, move_to_available, etc.) are implemented directly within the space module. These methods require explicitly passing agents (e.g., agent IDs or an AgentContainer). This approach can be cumbersome since there's no direct interface on AgentContainer itself.

💡 Proposed Solution

Implement a dedicated interface on AgentContainer classes that wraps these movement methods. By default, these methods would pass themselves as the agents to the underlying space methods, unless another set of agent IDs is explicitly provided.

This approach would significantly simplify the API and make it more intuitive.

🔄 Alternatives Considered

No response

➕ Additional Context

No response

@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Aug 26, 2024
@adamamer20 adamamer20 changed the title Add movement methods to AgentSetDF Add movement methods to AgentContainer Aug 26, 2024
@adamamer20 adamamer20 self-assigned this Sep 2, 2024
@adamamer20 adamamer20 added feature New functionality added to the project. good first issue Good for newcomers and removed enhancement Improvements to existing features or performance. labels Mar 18, 2025
@adamamer20 adamamer20 added this to the 0.1.0-stable milestone Mar 18, 2025
@adamamer20 adamamer20 changed the title Add movement methods to AgentContainer [Feature]: Add movement methods to AgentContainer Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality added to the project. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant