Skip to content

Commit 6cad3c3

Browse files
committed
Unescape innerHTML artifacts with workers
1 parent 78ae8f6 commit 6cad3c3

File tree

6 files changed

+20
-18
lines changed

6 files changed

+20
-18
lines changed

docs/core.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/core.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

esm/utils.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import dedent from 'codedent';
2+
import { unescape } from 'html-escaper';
23

34
const { isArray } = Array;
45

@@ -36,7 +37,7 @@ const dispatch = (target, type, worker = false, CE = CustomEvent) => {
3637
/* c8 ignore stop */
3738

3839
export {
39-
dedent,
40+
dedent, unescape,
4041
dispatch,
4142
isArray,
4243
assign,

esm/worker/url.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { INVALID_CONTENT, INVALID_SRC_ATTR, INVALID_WORKER_ATTR } from '../errors.js';
22

3-
import { dedent } from '../utils.js';
3+
import { dedent, unescape } from '../utils.js';
44

55
const hasCommentsOnly = text => !text
66
.replace(/\/\*[\s\S]*?\*\//g, '')
@@ -25,11 +25,11 @@ export default element => {
2525
else {
2626
const { innerHTML, localName, type } = element;
2727
const name = type || localName.replace(/-script$/, '');
28+
value = unescape(innerHTML);
2829
console.warn(
2930
`Deprecated: use <script type="${name}"> for an always safe content parsing:\n`,
30-
innerHTML,
31+
value,
3132
);
32-
value = innerHTML;
3333
}
3434

3535
const url = URL.createObjectURL(new Blob([dedent(value)], { type: 'text/plain' }));

package-lock.json

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@
6767
"@ungap/with-resolvers": "^0.1.0",
6868
"basic-devtools": "^0.1.6",
6969
"codedent": "^0.1.2",
70-
"coincident": "^0.13.3"
70+
"coincident": "^0.13.3",
71+
"html-escaper": "^3.0.3"
7172
},
7273
"worker": {
7374
"blob": "sha256-wpW1JDUswE7n7bkoJJYLv66C9OuoZbVItbc+oW3ttD8="

0 commit comments

Comments
 (0)