Skip to content

Commit 87e3e08

Browse files
authored
Fix broken docs-build by pinning protobuf-3.20.x
Differential Revision: D72016216 Pull Request resolved: #1033
1 parent d633108 commit 87e3e08

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

.github/workflows/doc-build.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,15 @@ jobs:
2020
architecture: x64
2121
- name: Checkout TorchX
2222
uses: actions/checkout@v2
23-
- name: Install Dependencies
23+
- name: Install Doc Dependencies
2424
run: |
2525
set -eux
2626
sudo apt-get update
2727
sudo apt-get install -y pandoc
28-
pip install -e .[dev]
2928
pip install -r docs/requirements.txt
3029
- name: Install TorchX
3130
run: |
32-
python setup.py develop
31+
pip install -e .[dev]
3332
- name: Start Airflow
3433
run: |
3534
# start airflow in background

.github/workflows/pyre.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ jobs:
2222
set -eux
2323
pip install -e .[dev]
2424
- name: Init Lint Runner
25-
lintrunner init
25+
run: lintrunner init
2626
- name: Run Pyre
2727
run: scripts/pyre.sh

dev-requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ google-cloud-runtimeconfig==0.34.0
1414
hydra-core
1515
ipython
1616
kfp==1.8.22
17+
# pin protobuf to the version that is required by kfp
18+
protobuf==3.20.3
1719
mlflow-skinny
1820
moto~=5.0.8
1921
pyre-extensions

torchx/schedulers/test/ray_scheduler_test.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,12 @@ def test_nonmatching_address(self) -> None:
390390
):
391391
_scheduler_with_client.submit(app=app, cfg={})
392392

393-
def _assertDictContainsSubset(self, expected, actual, msg=None):
393+
def _assertDictContainsSubset(
394+
self,
395+
expected: dict[str, Any],
396+
actual: dict[str, Any],
397+
msg: Optional[str] = None,
398+
) -> None:
394399
# NB: implement unittest.TestCase.assertDictContainsSubsetNew() since it was removed in python-3.11
395400
for key, value in expected.items():
396401
self.assertIn(key, actual, msg)

0 commit comments

Comments
 (0)