Skip to content

Typehint on torchvision.transforms.functional.pad should support both PIL.Image and Tensor #9258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Typehint on torchvision.transforms.functional.pad should support both PIL.Image and Tensor #9258

wants to merge 4 commits into from
+4 −4

Conversation

@dimidagd
Copy link

@dimidagd dimidagd commented Nov 5, 2025

Closes #9257

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9258

Note: Links to docs will display an error until the docs builds have been completed.

❌ 51 New Failures, 1 Unrelated Failure

As of commit 9945468 with merge base ca22124 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Nov 5, 2025

Hi @dimidagd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the cla signed label Nov 5, 2025
@dimidagd
Copy link
Author

dimidagd commented Nov 5, 2025

@NicolasHug I could not find a duplicate of this, perhaps you know better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type hints of torchvision are not constistent with implementation

1 participant

@dimidagd