Fix: correct handling of factors on x-axis

quantixed · quantixed · commit ff9cae7c3d78 · 2025-03-07T13:22:06.000Z
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: SuperPlotR
 Title: Making SuperPlots in R
-Version: 0.0.5
+Version: 0.0.6
 Authors@R:
     person(given = "Stephen J",
            family = "Royle",
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # SuperPlotR (development version)
 
+## SuperPlotR 0.0.6
+
+* Fixed factoring bug.
+
 ## SuperPlotR 0.0.5
 
 * Added `plainplot` function for simple plots.
diff --git a/R/superplot.R b/R/superplot.R
@@ -71,7 +71,8 @@ superplot <- function(df,
   }
 
   # if the cond column is not character, convert it
-  if (!is.character(df[[cond]])) {
+  # but only if it is not already a factor
+  if (!is.factor(df[[cond]]) && !is.character(df[[cond]])) {
     df[[cond]] <- as.character(df[[cond]])
   }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,8 @@ superplot <- function(df,`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`# if the cond column is not character, convert it`
`74`		`- if (!is.character(df[[cond]])) {`
	`74`	`+ # but only if it is not already a factor`
	`75`	`+ if (!is.factor(df[[cond]]) && !is.character(df[[cond]])) {`
`75`	`76`	`df[[cond]] <- as.character(df[[cond]])`
`76`	`77`	`}`
`77`	`78`