Skip to content

Commit 74942aa

Browse files
the mystery deepens
1 parent bf2061d commit 74942aa

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/workflows/testing_wheels.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ jobs:
4545
CIBW_BEFORE_BUILD: "pwd && ls"
4646
CIBW_REPAIR_WHEEL_COMMAND_MACOS: ""
4747
# due to package and module name conflict have to temporarily move it away to run tests
48-
# TODO: this might be the culprit, /project/qsimcirq doesn't exist in second go-round
49-
# CIBW_TEST_COMMAND_LINUX was overriding CIBW_TEST_COMMAND
50-
# Still need to prevent GPU tests from trying to run?
5148
CIBW_BEFORE_TEST: "mv {package}/qsimcirq /tmp"
5249
CIBW_TEST_COMMAND: "pytest {package}/qsimcirq_tests/qsimcirq_test.py && mv /tmp/qsimcirq {package}"
5350
steps:
@@ -67,7 +64,8 @@ jobs:
6764
# - tested CIBW_ENVIRONMENT: PATH=$PATH, no visible change
6865
# - new test: `which nvcc` in CIBW (FAILED)
6966
# - hardcoded PATH generates absurd errors?
70-
# - but the first wheel-build works. <===========
67+
# - but the first wheel-build works.
68+
# - reran with fixes and the result wheel didn't have GPU <===========
7169
# - next up:
7270
# - try https://github.com/OpenNMT/CTranslate2/blob/master/.github/workflows/ci.yml
7371
# - CIBW_BEFORE_ALL_LINUX: <script to install CUDA / add to PATH>

0 commit comments

Comments
 (0)