Skip to content

Commit a6248a2

Browse files
authored
fix: rustls version conflict when using questdb-rs (#77)
1 parent 2a936b3 commit a6248a2

File tree

30 files changed

+523
-301
lines changed

30 files changed

+523
-301
lines changed

ci/run_all_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def main():
3838
test_line_sender_path = next(iter(
3939
build_dir.glob(f'**/test_line_sender{exe_suffix}')))
4040
system_test_path = pathlib.Path('system_test') / 'test.py'
41-
qdb_v = '7.3.10' # The version of QuestDB we'll test against.
41+
qdb_v = '8.0.1' # The version of QuestDB we'll test against.
4242

4343
run_cmd('cargo', 'test', '--', '--nocapture', cwd='questdb-rs')
4444
run_cmd('cargo', 'test', '--all-features', '--', '--nocapture', cwd='questdb-rs')

corrosion/.github/actions/setup_test/action.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ runs:
3737
steps:
3838
- name: Cache Cargo registry
3939
id: cache-registry
40-
uses: actions/cache@v3
40+
uses: actions/cache@v4
4141
with:
4242
path: ~/.cargo/registry
4343
key: ${{ runner.os }}-cargo-registry
@@ -138,10 +138,10 @@ runs:
138138
arch: ${{ steps.arch_flags.outputs.msvc }}
139139
if: ${{ 'msvc' == steps.determine_abi.outputs.abi }}
140140
- name: Install CMake
141-
uses: corrosion-rs/install-cmake@v2
141+
uses: lukka/get-cmake@519de0c7b4812477d74976b2523a9417f552d126
142142
with:
143-
cmake: ${{inputs.cmake}}
144-
ninja: 1.10.0
143+
cmakeVersion: "${{ inputs.cmake }}"
144+
ninjaVersion: "~1.10.0"
145145
- name: Install Rust
146146
id: install_rust
147147
uses: dtolnay/rust-toolchain@master

corrosion/.github/workflows/gh-pages.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
name: github-pages
2525
url: ${{ steps.deployment.outputs.page_url }}
2626
steps:
27-
- uses: actions/checkout@v3
27+
- uses: actions/checkout@v4
2828
- name: Setup Pages
2929
uses: actions/configure-pages@v3
3030
- name: Install mdbook
@@ -39,7 +39,7 @@ jobs:
3939
cd doc
4040
mdbook build
4141
# Override mdbooks default highlight.js with a custom version containing CMake support.
42-
- uses: actions/checkout@v3
42+
- uses: actions/checkout@v4
4343
with:
4444
repository: 'highlightjs/highlight.js'
4545
# mdbook currently (as of v0.4.27) does not support v11 yet.

corrosion/.github/workflows/test.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
name: Test MSRV of the new lockfile
5454
runs-on: ubuntu-20.04
5555
steps:
56-
- uses: actions/checkout@v3
56+
- uses: actions/checkout@v4
5757
- name: Install Rust
5858
id: install_rust
5959
uses: dtolnay/rust-toolchain@1.56
@@ -164,7 +164,7 @@ jobs:
164164
abi: gnu
165165

166166
steps:
167-
- uses: actions/checkout@v3
167+
- uses: actions/checkout@v4
168168
- name: Setup Environment and Configure CMake
169169
uses: "./.github/actions/setup_test"
170170
with:
@@ -204,13 +204,13 @@ jobs:
204204
cmake: 3.21.5 # VS on windows-2022 requires at least CMake 3.21
205205

206206
steps:
207-
- uses: actions/checkout@v3
207+
- uses: actions/checkout@v4
208208
# The initial configure for MSVC is quite slow, so we cache the build directory
209209
# (including the build directories of the tests) since reconfiguring is
210210
# significantly faster.
211211
- name: Cache MSVC build directory
212212
id: cache-msvc-builddir
213-
uses: actions/cache@v3
213+
uses: actions/cache@v4
214214
with:
215215
path: build
216216
key: ${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.rust }}-msvc-build
@@ -243,8 +243,8 @@ jobs:
243243
# - os: windows-2019
244244
# abi: gnu
245245
steps:
246-
- uses: actions/checkout@v3
247-
- uses: actions/cache@v3
246+
- uses: actions/checkout@v4
247+
- uses: actions/cache@v4
248248
id: cache_cxxbridge
249249
with:
250250
path: "~/.cargo/bin/cxxbridge*"
@@ -283,15 +283,15 @@ jobs:
283283
- os: macos-12
284284
rust: 1.54.0 # On MacOS-12 linking fails before Rust 1.54
285285
steps:
286-
- uses: actions/checkout@v3
286+
- uses: actions/checkout@v4
287287
- name: Setup MSVC Development Environment
288288
uses: ilammy/msvc-dev-cmd@v1
289289
if: runner.os == 'Windows'
290290
- name: Install CMake
291-
uses: corrosion-rs/install-cmake@v2
291+
uses: lukka/get-cmake@519de0c7b4812477d74976b2523a9417f552d126
292292
with:
293-
cmake: 3.18.0
294-
ninja: 1.10.0
293+
cmakeVersion: "~3.18.0"
294+
ninjaVersion: "~1.10.0"
295295
- name: Install Rust
296296
uses: dtolnay/rust-toolchain@master
297297
with:

corrosion/.github/workflows/test_legacy.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ jobs:
2626
strategy:
2727
fail-fast: false
2828
steps:
29-
- uses: actions/checkout@v3
29+
- uses: actions/checkout@v4
3030
- name: Cache Legacy Generator
3131
id: cache_generator
32-
uses: actions/cache@v3
32+
uses: actions/cache@v4
3333
with:
3434
path: ${{github.workspace}}/corrosion-prebuilt-generator
3535
key: ${{ runner.os }}-${{ inputs.rust }}-generator-${{ hashFiles('generator/src/**', 'generator/Cargo.toml', 'generator/Cargo.lock') }}

corrosion/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ project(Corrosion
55
# tagged release. Users don't need to care about this, it is mainly to
66
# clearly see in configure logs which version was used, without needing to
77
# rely on `git`, since Corrosion may be installed or otherwise packaged.
8-
VERSION 0.4.3
8+
VERSION 0.5.0
99
LANGUAGES NONE
1010
HOMEPAGE_URL "https://corrosion-rs.github.io/corrosion/"
1111
)

corrosion/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ include(FetchContent)
2727
FetchContent_Declare(
2828
Corrosion
2929
GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
30-
GIT_TAG v0.4 # Optionally specify a commit hash, version tag or branch here
30+
GIT_TAG v0.5 # Optionally specify a commit hash, version tag or branch here
3131
)
3232
FetchContent_MakeAvailable(Corrosion)
3333

corrosion/RELEASES.md

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,100 @@
1+
# v0.5.0 (2024-05-11)
2+
3+
### Breaking Changes
4+
5+
- Dashes (`-`) in names of imported CMake **library** targets are now replaced with underscores (`_`).
6+
See [issue #501] for details. Users on older Corrosion versions will experience the same
7+
change when using Rust 1.79 or newer. `bin` targets are not affected by this change.
8+
9+
[issue #501]: https://github.com/corrosion-rs/corrosion/issues/501
10+
11+
# v0.4.10 (2024-05-11)
12+
13+
### New features
14+
15+
- `corrosion_experimental_cbindgen()` can now be called multiple times on the same Rust target,
16+
as long as the output header name differs. This may be useful to generate separate C and C++
17+
bindings. [#507]
18+
- If `corrosion_link_libraries()` is called on a Rust static library target, then
19+
`target_link_libraries()` is called to propagate the dependencies to C/C++ consumers.
20+
Previously a warning was emitted in this case and the arguments ignored. [#506]
21+
22+
### Fixes
23+
24+
- Combine `-framework` flags on macos to avoid linker deduplication errors [#455]
25+
- `corrosion_experimental_cbindgen()` will now correctly use the package name, instead of assuming that
26+
the package and crate name are identical. ([11e27c])
27+
- Set the `AR_<triple>` variable for `cc-rs` (except for msvc targets) [#456]
28+
- Fix hostbuild when cross-compiling to windows [#477]
29+
- Consider vworks executable suffix [#504]
30+
- `corrosion_experimental_cbindgen()` now forwards the Rust target-triple (e.g. `aarch64-unknown-linux-gnu`)
31+
to cbindgen via the `TARGET` environment variable. The `hostbuild` property is considered. [#507]
32+
- Fix linking errors with Rust >= 1.79 and `-msvc` targets.` [#511]
33+
34+
35+
[#455]: https://github.com/corrosion-rs/corrosion/pull/455
36+
[#456]: https://github.com/corrosion-rs/corrosion/pull/456
37+
[#477]: https://github.com/corrosion-rs/corrosion/pull/477
38+
[#504]: https://github.com/corrosion-rs/corrosion/pull/504
39+
[#506]: https://github.com/corrosion-rs/corrosion/pull/506
40+
[#507]: https://github.com/corrosion-rs/corrosion/pull/507
41+
[#511]: https://github.com/corrosion-rs/corrosion/pull/511
42+
[11e27c]: https://github.com/corrosion-rs/corrosion/pull/514/commits/11e27cde2cf32c7ed539c96eb03c2f10035de538
43+
44+
# v0.4.9 (2024-05-01)
45+
46+
### New Features
47+
48+
- Automatically detect Rust target for OpenHarmony ([#510]).
49+
50+
### Fixes
51+
52+
- Make find_package portable ([#509]).
53+
54+
[#510]: https://github.com/corrosion-rs/corrosion/pull/510
55+
[#509]: https://github.com/corrosion-rs/corrosion/pull/509
56+
57+
# v0.4.8 (2024-04-03)
58+
59+
### Fixes
60+
61+
- Fix an internal error when passing both the `PROFILE` and `CRATES` option to
62+
`corrosion_import_crate()` ([#496]).
63+
64+
[#496]: https://github.com/corrosion-rs/corrosion/pull/496
65+
66+
# v0.4.7 (2024-01-19)
67+
68+
### Fixes
69+
70+
- The C/C++ compiler passed from corrosion to `cc-rs` can now be overriden by users setting
71+
`CC_<target>` (e.g. `CC_x86_64-unknown-linux-gnu=/path/to/my-compiler`) environment variables ([#475]).
72+
73+
[#475]: https://github.com/corrosion-rs/corrosion/pull/475
74+
75+
# v0.4.6 (2024-01-17)
76+
77+
### Fixes
78+
79+
- Fix hostbuild executables when cross-compiling from non-windows to windows targets.
80+
(Only with CMake >= 3.19).
81+
82+
# v0.4.5 (2023-11-30)
83+
84+
### Fixes
85+
86+
- Fix hostbuild executables when cross-compiling on windows to non-windows targets
87+
(Only with CMake >= 3.19).
88+
89+
# v0.4.4 (2023-10-06)
90+
91+
### Fixes
92+
93+
- Add `chimera` ([#445]) and `unikraft` ([#446]) to the list of known vendors
94+
95+
[#445]: https://github.com/corrosion-rs/corrosion/pull/445
96+
[#446]: https://github.com/corrosion-rs/corrosion/pull/446
97+
198
# v0.4.3 (2023-09-09)
299

3100
### Fixes

0 commit comments

Comments
 (0)