Skip to content

Commit 11a43da

Browse files
committed
Minor usability improvments
1 parent f513d92 commit 11a43da

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

distribution/lambda/cdk/stacks/examples/hdfs_stack.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def __init__(
5151
searcher_memory_size=searcher_memory_size,
5252
indexer_package_location=indexer_package_location,
5353
searcher_package_location=searcher_package_location,
54+
indexer_timeout=aws_cdk.Duration.minutes(10),
5455
)
5556

5657
aws_cdk.CfnOutput(

distribution/lambda/cdk/stacks/services/indexer_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ def __init__(
1313
index_config_bucket: str,
1414
index_config_key: str,
1515
memory_size: int,
16+
timeout: aws_cdk.Duration,
1617
environment: dict[str, str],
1718
asset_path: str,
1819
**kwargs,
@@ -32,8 +33,7 @@ def __init__(
3233
"QW_LAMBDA_INDEX_CONFIG_URI": f"s3://{index_config_bucket}/{index_config_key}",
3334
**environment,
3435
},
35-
# use a strict timeout and retry policy to avoid unexpected costs
36-
timeout=aws_cdk.Duration.minutes(1),
36+
timeout=timeout,
3737
retry_attempts=0,
3838
reserved_concurrent_executions=1,
3939
memory_size=memory_size,

distribution/lambda/cdk/stacks/services/quickwit_service.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ def __init__(
3232
indexer_package_location: str,
3333
indexer_memory_size: int = DEFAULT_LAMBDA_MEMORY_SIZE,
3434
indexer_environment: dict[str, str] = {},
35+
# small default timeout to avoid unexpected costs and hanging indexers
36+
indexer_timeout: aws_cdk.Duration = aws_cdk.Duration.minutes(1),
3537
searcher_memory_size: int = DEFAULT_LAMBDA_MEMORY_SIZE,
3638
searcher_environment: dict[str, str] = {},
3739
**kwargs,
@@ -55,6 +57,7 @@ def __init__(
5557
index_config_bucket=index_config_bucket,
5658
index_config_key=index_config_key,
5759
memory_size=indexer_memory_size,
60+
timeout=indexer_timeout,
5861
environment=indexer_environment,
5962
asset_path=indexer_package_location,
6063
)

quickwit/quickwit-lambda/src/searcher/api.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ async fn create_local_search_service(
4848
let searcher_pool = SearcherPool::default();
4949
let search_job_placer = SearchJobPlacer::new(searcher_pool.clone());
5050
let cluster_client = ClusterClient::new(search_job_placer);
51+
// TODO configure split cache
5152
let searcher_context = Arc::new(SearcherContext::new(searcher_config, None));
5253
let search_service = Arc::new(SearchServiceImpl::new(
5354
metastore,

0 commit comments

Comments
 (0)