Skip to content

Commit abc53da

Browse files
authored
Fix MinIO configuration to always set region to 'minio. Fixes #5822 (#5823)
1 parent 6ec8841 commit abc53da

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/configuration/storage-config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ The Google Cloud Storage flavor (`gcs`) turns off multi-object delete requests a
9090

9191
*MinIO flavor*
9292

93-
The MinIO flavor (`minio`) forces path-style access.
93+
The MinIO flavor (`minio`) overrides the `region` parameter to `minio` and forces path-style access.
9494

9595
Example of a storage configuration for Google Cloud Storage in YAML format:
9696

quickwit/quickwit-config/src/storage_config.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ impl S3StorageConfig {
347347
self.disable_multipart_upload = true;
348348
}
349349
Some(StorageBackendFlavor::MinIO) => {
350+
self.region = Some("minio".to_string());
350351
self.force_path_style_access = true;
351352
}
352353
_ => {}
@@ -497,6 +498,7 @@ mod tests {
497498
assert!(gcs_storage_config.disable_multipart_upload);
498499

499500
let minio_storage_config = storage_configs[3].as_s3().unwrap();
501+
assert_eq!(minio_storage_config.region, Some("minio".to_string()));
500502
assert!(minio_storage_config.force_path_style_access);
501503
}
502504

0 commit comments

Comments
 (0)