Skip to content

Use RMQ_ERLC_OPTS for ERL_COMPILER_OPTIONS #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Aug 1, 2025

This is a follow-up to commit 93db480

This should make the deterministic flag optional again for local re-compile using c() in the erl shell.

I'm also looking into why the two *_sql_* files are modified on every build...

lrbakken@SEA-3LG5HVJUWJK ~/development/rabbitmq/rabbitmq-server (lukebakken/make-deterministic-optional-again *)
$ git st
On branch lukebakken/make-deterministic-optional-again
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   deps/rabbit/Makefile
        modified:   deps/rabbit/src/rabbit_amqp_sql_lexer.erl
        modified:   deps/rabbit/src/rabbit_amqp_sql_parser.erl

@lukebakken lukebakken self-assigned this Aug 1, 2025
@mergify mergify bot added the make label Aug 1, 2025
@michaelklishin
Copy link
Collaborator

Should we tweak RMQ_ERLC_OPTS defaults to include deterministic?

@lukebakken
Copy link
Collaborator Author

RMQ_ERLC_OPTS already does! This change is so that if someone wants to ensure deterministic is not used anywhere (i.e. you're going to re-compile code in the rabbit app in the erl shell), they run this:

make RMQ_ERLC_OPTS=''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants