Fix after lint and add test

Author: vanilevsky

cmd/description/main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"context"
 	"fmt"
-	"github.com/ravilushqa/gpt-pullrequest-updater/shortcut"
 	"os"
 	"os/signal"
 	"syscall"
@@ -15,6 +14,7 @@ import (
 	ghClient "github.com/ravilushqa/gpt-pullrequest-updater/github"
 	"github.com/ravilushqa/gpt-pullrequest-updater/jira"
 	oAIClient "github.com/ravilushqa/gpt-pullrequest-updater/openai"
+	"github.com/ravilushqa/gpt-pullrequest-updater/shortcut"
 )
 
 var opts struct {
@@ -26,7 +26,7 @@ var opts struct {
 	OpenAIModel     string `long:"openai-model" env:"OPENAI_MODEL" description:"OpenAI model" default:"gpt-3.5-turbo"`
 	Test            bool   `long:"test" env:"TEST" description:"Test mode"`
 	JiraURL         string `long:"jira-url" env:"JIRA_URL" description:"Jira URL. Example: https://jira.atlassian.com"`
-	ShortcutBaseURL string `long:"shortcut-url" env:"SHORTCUT_URL" description:"Shortcut URL. Example: https://app.shortcut.com/foo/"`
+	ShortcutBaseURL string `long:"shortcut-url" env:"SHORTCUT_URL" description:"Shortcut URL. Example: https://app.shortcut.com/foo"`
 }
 
 func main() {
@@ -110,5 +110,5 @@ func buildShortcutContent(shortcutBaseURL string, pr *github.PullRequest) string
 		return ""
 	}
 
-	return fmt.Sprintf("### Shortcut story: [%s](%s)", id, shortcut.GenerateShortcutStoryUrl(shortcutBaseURL, id))
+	return fmt.Sprintf("### Shortcut story: [%s](%s)", id, shortcut.GenerateShortcutStoryURL(shortcutBaseURL, id))
 }

shortcut/shortcut.go

@@ -5,7 +5,7 @@ import (
 	"regexp"
 )
 
-const storyUrlFormat = "%s/story/%s"
+const storyURLFormat = "%s/story/%s"
 
 func ExtractShortcutStoryID(title string) (string, error) {
 
@@ -24,6 +24,6 @@ func ExtractShortcutStoryID(title string) (string, error) {
 	return matches[1], nil
 }
 
-func GenerateShortcutStoryUrl(shortcutBaseUrl, ticketId string) string {
-	return fmt.Sprintf(storyUrlFormat, shortcutBaseUrl, ticketId)
+func GenerateShortcutStoryURL(shortcutBaseUrl, ticketId string) string {
+	return fmt.Sprintf(storyURLFormat, shortcutBaseUrl, ticketId)
 }

shortcut/shortcut_test.go

@@ -0,0 +1,51 @@
+package shortcut
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestExtractShortcutStoryID(t *testing.T) {
+	testCases := []struct {
+		title       string
+		expectedID  string
+		expectedErr bool
+	}{
+		{
+			title:       "This is a sample title with a valid story ID sc-12345",
+			expectedID:  "12345",
+			expectedErr: false,
+		},
+		{
+			title:       "No story ID in this title",
+			expectedID:  "",
+			expectedErr: true,
+		},
+		{
+			title:       "Invalid story ID format sc-abcde",
+			expectedID:  "",
+			expectedErr: true,
+		},
+	}
+
+	for _, tc := range testCases {
+		id, err := ExtractShortcutStoryID(tc.title)
+
+		if tc.expectedErr {
+			assert.Error(t, err)
+		} else {
+			assert.NoError(t, err)
+			assert.Equal(t, tc.expectedID, id)
+		}
+	}
+}
+
+func TestGenerateShortcutStoryURL(t *testing.T) {
+	baseURL := "https://app.shortcut.com/foo"
+	ticketID := "12345"
+	expectedURL := "https://app.shortcut.com/foo/story/12345"
+
+	url := GenerateShortcutStoryURL(baseURL, ticketID)
+	assert.Equal(t, expectedURL, url)
+}