Skip to content

Commit 5d9d55b

Browse files
authored
Partial revert of #12369 for celery visibility timeout (#12442)
We are noticing all builds restarting at 17.25m (15m * 115%), reverting this back to 5hours for now. In theory, tasks are being executed with ack_late=False so they should immediately acknowledge the task and avoid the visibility timeout entirely. But in practice this doesn't seem to happen and the build task acts like ack_late=True with a 17.25min visibility timeout, duplicating the build task on another builder. - Related #12369 - We discussed the potential for low timeout bugs at #12393 - This bug is identical to #12317 except the timeout is 17m now instead of 1h
1 parent d9f56e0 commit 5d9d55b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

readthedocs/settings/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ def BUILD_MEMORY_LIMIT(self):
640640
# https://github.com/readthedocs/readthedocs.org/issues/12317#issuecomment-3070950434
641641
# https://docs.celeryq.dev/en/stable/getting-started/backends-and-brokers/redis.html#visibility-timeout
642642
BROKER_TRANSPORT_OPTIONS = {
643-
'visibility_timeout': BUILD_TIME_LIMIT * 1.15, # 15% more than the build time limit
643+
'visibility_timeout': 18000, # 5 hours
644644
}
645645

646646
CELERY_DEFAULT_QUEUE = "celery"

0 commit comments

Comments
 (0)