Skip to content

Use only one setting for build limit #12347

@humitos

Description

@humitos

We have different settings that can make the build to have different time limits:

  • Docker container time limit global: settings.DOCKER_LIMITS['time']
  • Docker container time limit per project: project.container_time_limit
  • Celery max time for the builder to ACK the task before reschedule: settings.BROKER_TRANSPORT_OPTIONS['visibility_timeout']
  • Build API key expire datetime: BuildAPIKey.expiry_date
  • ... it may be more settings here that I may be missing.

All of these values should be the same. Otherwise, if the build can run for 4 hours, but the API key is valid only for 3 hours, it will fail.

Related:

Metadata

Metadata

Assignees

Labels

AcceptedAccepted issue on our roadmapImprovementMinor improvement to code

Type

No type

Projects

Status

Needs review

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions